Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9193: maternity and child health clinic search #865

Merged
merged 8 commits into from
Dec 22, 2023
Merged

UHF-9193: maternity and child health clinic search #865

merged 8 commits into from
Dec 22, 2023

Conversation

j-mys
Copy link
Contributor

@j-mys j-mys commented Dec 22, 2023 •
edited
Loading

UHF-9193

What was done

  • React search for maternity and child health clinics
  • Almost identical to health station search

How to install

  • Make sure SOTE instance is up and running on latest UHF-9193_maternity_clinic_search branch.
    • git pull origin UHF-9193_maternity_clinic_search
    • git checkout UHF-9193_maternity_clinic_search
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9193_maternity_clinic_search
  • Run make drush-cr

How to test

  • Add maternity clinic search to landing page
  • Check that the search gets items
  • Check that the checkbox for swedish service changes result
  • Check that the map is showing pins

Designers review

  • This PR does not need designers review

Other PRs

Platform: City-of-Helsinki/drupal-helfi-platform-config#672
Instance: City-of-Helsinki/drupal-helfi-sote#732

@j-mys j-mys mentioned this pull request Dec 22, 2023
Merged
@Jussiles Jussiles self-requested a review December 22, 2023 07:08
Jussiles
Jussiles suggested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly great! 🦜 Added some comments that you could check and fix.

hdbt.libraries.yml Outdated Show resolved Hide resolved
src/js/react/apps/maternity-and-child-health-clinic-search/index.tsx Outdated Show resolved Hide resolved
...s/react/apps/maternity-and-child-health-clinic-search/types/MaternityAndChildHealthClinic.ts Outdated Show resolved Hide resolved
src/js/react/apps/maternity-and-child-health-clinic-search/types/SubmitEventTarget.ts Outdated Show resolved Hide resolved
templates/paragraphs/paragraph--maternity-and-child-health-clini.html.twig Outdated Show resolved Hide resolved
@j-mys j-mys mentioned this pull request Dec 22, 2023
Merged
Jussiles
Jussiles approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyvää työtä! hyvää joulua ja onnellista uutta vuotta! 🌟

@j-mys j-mys merged commit ba0fad9 into main Dec 22, 2023
1 check passed
@j-mys j-mys deleted the UHF-9193_maternity_clinic_search branch December 22, 2023 13:08
This was referenced Dec 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mys @Jussiles