UHF-9050 button refactor #785
Conversation
…tyles for the button v2 - probably needs a better name. :)
| padding: var(--spacing-2-xs) var(--spacing-2-xs); | ||
| } | ||
|
|
||
| /* FULL WIDTH */ |
There was a problem hiding this comment.
Change to one-line-comment style.
There was a problem hiding this comment.
Oops, right, these must have slipt past when changing HDS CSS comments to SCSS comments on our side
| input[type='button'].hds-button--small, | ||
| input[type='reset'].hds-button--small, | ||
| input[type='submit'].hds-button--small { | ||
| padding: var(--spacing-2-xs) var(--spacing-m); |
There was a problem hiding this comment.
This is overriding styles set on line 191. Is this intentional?
There was a problem hiding this comment.
This part of our code tries to closely follow HDS codes. This part is in https://github.com/City-of-Helsinki/helsinki-design-system/blob/dea8dde508c1f536eea84175be9c1a62d4f83878/packages/core/src/components/button/button.css#L232C12-L232C12 and has a same problem. So kind of intentional on our end, but do not know how intentional is it is on their end.
|
Closing this PR as the same feature and changes was merged in #810 |
UHF-9050
What was done
How to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-9050_button_refactormake drush-crHow to test
Designers review
Other PRs