Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8799 broken image breaks layout #754

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Aug 25, 2023

UHF-8799

If an image loading fails, content liftup component breaks layout.

What was done

  • Added width: auto to image seems to fix this issue. 🤷

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8799_broken_image_breaks_layout
  • Run make drush-cr

How to test

  • Check that broken images do not break layout anymore
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@teroelonen teroelonen changed the title Uhf 8799 broken image breaks layout UHF-8799 broken image breaks layout Aug 25, 2023
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked well 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants