Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8714: Change the sidebar text block background color to gray #748

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 17, 2023

UHF-8714

What was done

  • Changed the sidebar text block background color to gray.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8714_change_sidebar_background_color
  • Run make drush-cr

How to test

  • Go to any standard page or TPR unit or TPR service and add content to sidebar. Select the text block and paste the html-dom that is linked below.
  • Check that all the elements have gray background now instead of the secondary colors that were coming from the color palette before.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)
<p>Here is a text paragraph.</p>

<ul>
	<li>This is a list</li>
	<li>This is a list</li>
	<li>This is a list</li>
</ul>

<p>More text here again.</p>

<ol>
	<li>This is a list</li>
	<li>This is a list</li>
	<li>This is a list</li>
</ol>

<p><a class="hds-button hds-button--secondary" data-design="hds-button hds-button--secondary" data-is-external="true" data-link-text="Google.com" data-protocol="https" data-selected-icon="google" href="https://google.com"><span class="hds-button__label">Google.com</span></a></p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants