Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Update prettier and related packages #746

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Aug 15, 2023

What was done

  • Update prettier and related packages
  • Remove unused imports

How to install

  • Make sure KASKO instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X-update-prettier-and-related-packages
  • Run make shell to log into container
  • Run drush sapi-rt; drush sapi-c; drush sapi-i; drush cr to update Elastic indexes and clear drupal cache

How to test

  • Check that site and styles still work and look good
  • Check that School search and Event search still work. You need to add School search and Events paragraphs to landing page node for testing https://helfi-kasko.docker.so/en/childhood-and-education/node/add/landing_page. Events paragraph need API URL. You can use https://tapahtumat.hel.fi/fi/events?categories=museum
  • Check also that Accordion works as before. Accordions are added as paragraphs to a node.
  • Check that developing, building and linting HDBT still works
  • Check that code follows our standards

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants