Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7418 Phasing component accessibility changes #648

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Apr 28, 2023

UHF-7418

What was done

  • Changed numbered phasing component to use ol tag instead of ul.
  • Switched the before and after pseudo elements other way around so that the number is read first with screen readers.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-7418_phasing_component_accessibility_changes
  • Run make drush-cr

How to test

  • Go and create a phasing components: one with just one item, other one with few items. Make sure they have the numbering turned on.
  • Save the content and make sure that the layout looks good as before.
  • Check with inspector that the structure of the element for the screen reader is so that the number is first. Check the screenshot for what the element should look like.
  • Check that code follows our standards

Screenshot 2023-04-28 at 15 01 25

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

… ul, switched the before and after pseudo elements other way around so that the number is read first with screen readers
@juho-lehmonen juho-lehmonen self-requested a review April 28, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants