UHF-8128: Missing H1

[khalima]

UHF-8128

What was done

• Added constraint for missing hero block entities in entity forms and enhanced the checks for the hero block to prevent missing H1 elements.

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the Helfi Platform config and the HDBT theme
  • composer require drupal/helfi_platform_config:dev-UHF-8128_missing_h1 drupal/hdbt:dev-UHF-8128_missing_h1
• Import translations by running drush locale:check; drush locale:update in shell
• Run make drush-cr

How to test

• Go to create or edit a landing page

  • Check the Hero checkbox and remove hero paragraph from the three dots
    
  • Try to save the landing page and check that there's a warning message: Hero paragraph is mandatory if the Hero checkbox has been selected. Either unselect the checkbox or create the hero paragraph by clicking the Add Hero button.
  • Uncheck the Hero checkbox or add the hero paragraph and retry to save the landing page. It should now work.

• Open public/modules/contrib/helfi_platform_config/modules/hdbt_admin_tools/src/Plugin/Validation/Constraint/HeroConstraintValidator.php in your IDE and comment the line 29 $this->context->addViolation($constraint->heroRequired);

• Clear the caches and go to edit the landing page. Check the Hero checkbox and remove the paragraph. Save the landing page.

  • Check that the landing page title is displayed on the page even if the Hero checkbox is checked and hero paragraph is missing.
  • Go to edit the page again, re-add the hero paragraph, save the node and check that the hero is displayed on the page again

• Check that code follows our standards

Other PRs

• UHF-8128: Missing H1 drupal-helfi-platform-config#503

[teroelonen]

Worked perfectly 🦖