Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7795 Icons #634

Merged
merged 2 commits into from
Apr 19, 2023
Merged

UHF-7795 Icons #634

merged 2 commits into from
Apr 19, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Apr 18, 2023

UHF-7795

What was done

  • Updated HDS icons.
  • Compiled icons and icon json files.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-7795_icons
  • Run make drush-cr

How to test

  • Go to create a banner paragraph to some node and check that the following icons are found:
    • family
    • traveler
    • mover
    • youth
    • senior
    • entrepreneur
    • children
    • vaccine
    • virus
    • key
    • occupation
    • company
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

  • Link to other PR

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and changes look good, and work on my machine as described. Good job! Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants