UHF-X: Remove aria-haspopup from dropdown menu #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As WAI-ARIA spec has changed to limit the usage of this attribute only to role="menu", we got recommendation from Siteimprove Tero P to stop using this previously recommended practise.
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-X
As WAI-ARIA spec has changed to limit the usage of this attribute only to role="menu", we got recommendation from Siteimprove Tero P to stop using this previously recommended practise.
Check #dev-helfi-hds channel in slack for more info.
What was done
aria-haspopupattribute was removed as recommended by expertsHow to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-X_remove_aria_haspopupmake drush-crHow to test
aria-haspopupwas removed properlyDesigners review