Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-5047: Cookie content blocker on TPR unit maps #566

Merged
merged 1 commit into from
Feb 28, 2023
Merged

UHF-5047: Cookie content blocker on TPR unit maps #566

merged 1 commit into from
Feb 28, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Feb 27, 2023 •
edited by teroelonen
Loading

UHF-5047

The cookie content blocker didn't work on TPR unit pages.

What was done

  • Use the cookie content blocker template also on TPR unit maps.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-5047_TPR-unit-map-cookies
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review

teroelonen
teroelonen approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go 🦖

@dire dire merged commit 6065c40 into main Feb 28, 2023
@dire dire deleted the UHF-5047_TPR-unit-map-cookies branch February 28, 2023 07:38
This was referenced Feb 28, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dire @teroelonen