Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Add missing quotes around html attribute values #559

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Feb 21, 2023

UHF-X

Siteimprove was complaining about duplicate ids on a page: https://www.hel.fi/fi/paatoksenteko-ja-hallinto/sisallonhallinta/sivujen-rakentaminen-drupalissa/sivupohjat-ja-niiden-valinta/perussivu/esimerkki

It turned out that we had a id that leaked its contents as it did not have quotes arounds its empty value.

What was done

  • Checked for other such problems and found potential problems in multiple places.
  • The places where attributes were set without quotes were fixed in this PR
  • The id did not have contents because the variable was misnamed, this was fixed

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_fix_html_attributes_missing_quotes
  • Run make drush-cr

How to test

  • Check that the new accordions still work
  • Check that menu links with lang attribute still work
  • Check that pager still works
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@Arkkimaagi Arkkimaagi marked this pull request as ready for review February 21, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants