-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-7794 Accordion #541
Merged
Merged
UHF-7794 Accordion #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erated by this module
…ntation, added missing aria-controls structures to the templates with unique id
…y-of-Helsinki/drupal-hdbt into UHF-7794_accordion
…ng and hover for accordion toggle button
…ved pointer-elements none from styles to fix issue with close button having to be clicked twice
…y-of-Helsinki/drupal-hdbt into UHF-7794_accordion
…ent to fix issue with toc, fixed icon styling on close button and moved it to pseudo element
…y-of-Helsinki/drupal-hdbt into UHF-7794_accordion
teroelonen
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was really nice 🦖 Also was super nice to work with you on this!
…drupal-hdbt into UHF-7794_accordion
…y-of-Helsinki/drupal-hdbt into UHF-7794_accordion
This was referenced Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-7794
Created javascript library to replace the handorgel-accordion library
What was done
How to install
git pull origin dev
make fresh
composer require drupal/hdbt:dev-UHF-7794_accordion
composer require drupal/helfi_platform_config:dev-UHF-7794_accordion
make drush-cr
How to test
Other PRs
City-of-Helsinki/drupal-helfi-platform-config#432