Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOM-300 Accessibility fixes #528

Merged
merged 3 commits into from
Feb 1, 2023
Merged

LOM-300 Accessibility fixes #528

merged 3 commits into from
Feb 1, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 30, 2023 •
edited
Loading

LOM-300

What was done

  • Adds more comprehensive is-hidden class for hdbt.
  • Enables the refresh-icon to be used on the theme.

How to install

  • Make sure your form-tool instance is up and running on LOM-300_accessibility_fixes branch.
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-LOM-300_accessibility_fixes
  • Run make drush-cr

How to test

  • Check the testing instructions from LOM-300 PR on the form-tool repository.
  • Check that code follows our standards

Other PRs

@teroelonen teroelonen mentioned this pull request Jan 30, 2023
Merged
14 tasks
@teroelonen teroelonen marked this pull request as ready for review January 30, 2023 16:46
Arkkimaagi
Arkkimaagi requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing to ponder before we proceed. 🤔

templates/misc/icon.twig Outdated

<span class="hel-icon hel-icon--{{ icon }} {{ class }}" role="img" {% if label %} aria-labelledby="{{ icon_labelled_by }}" {% else %} aria-hidden="true" {% endif %}>
{% if label %}
<span class="visually-hidden" id="{{ icon_labelled_by }}">{{ label }}</span>
Copy link
Contributor

@Arkkimaagi Arkkimaagi Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be is-hidden instead of visually-hidden as aria-labelledby should work just as well with display:none? This way ios 15 would work a bit better and we'd have even less of a chance of the label being read twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is switched now.

Arkkimaagi
Arkkimaagi approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good job! 🚀

@teroelonen teroelonen merged commit 0dadf35 into main Feb 1, 2023
@teroelonen teroelonen deleted the LOM-300_accessibility_fixes branch February 1, 2023 07:52
This was referenced Feb 1, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkkimaagi Arkkimaagi Arkkimaagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @Arkkimaagi