Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uhf 7829 swedish og image #524

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Uhf 7829 swedish og image #524

merged 3 commits into from
Jan 20, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Jan 18, 2023 •
edited by khalima
Loading

UHF-7829

When sharing a page in Swedish, the default og image has Helsinki in Finnish instead of Helsingfors.

What was done

  • Added logic that changes the image to Swedish one when needed.

How to install

  • Have some instance running.
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-7829_swedish-og-image
  • Run make drush-cr

How to test

  • Check the og image metatag on all languages. Swedish one should have the og-global-sv.png as the default image.

Designers review

  • This PR does not need designers review

khalima
khalima approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! 🚀

@dire dire merged commit 7164a22 into main Jan 20, 2023
@dire dire deleted the UHF-7829_swedish-og-image branch January 20, 2023 07:15
This was referenced Jan 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dire @khalima