Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Fix list of links item heading level #517

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Jan 12, 2023

UHF-X

Siteimprove reports mixed heading levels on pages that do not have h2 and contain list-of-links with no title. (h1 --> h3) For example: Symppis

What was done

  • A check was added to list-of-links for paragraph title that toggles h2 or h3 level for links.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_list_of_links_h_level
  • Run make drush-cr

How to test

  • Check that list of links item heading levels work with and without paragraph title (either h3 or h2)
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants