Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7249: Changed popular services paragraph to use title field if it… #504

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

lonkaanna
Copy link
Contributor

@lonkaanna lonkaanna commented Dec 15, 2022

UHF-7249

What was done

  • Changed popular services paragraph template to use the new title field if it has content, if it's empty the title should default to "Popular services"

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-0000_insert_correct_branch
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-7249-popular-services-editable-title
  • Run make drush-updb drush-cr

How to test

  • Create a landing page and add the popular services paragraph to it. As default the title value should be "Popular services" (in what ever language is chosen)
  • Save the page and check that the title is rendered correctly
  • Edit the title, save it and check that it appears
  • Remove the title completely, it should default to "Popular services"
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants