Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7008: Fixed PHP coding standards #186

Merged
merged 13 commits into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/hdbt_admin_tools/src/Controller/ListController.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class ListController {
* @return array
* Render array.
*/
public function build() {
public function build(): array {
$current_user = User::load(\Drupal::currentUser()->id());
$faked_blocks = [];

Expand Down
4 changes: 2 additions & 2 deletions modules/select2_icon/src/Element/Select2IconFormElement.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Select2IconFormElement extends Select2 {
/**
* {@inheritdoc}
*/
public static function processSelect(&$element, FormStateInterface $form_state, &$complete_form) {
public static function processSelect(&$element, FormStateInterface $form_state, &$complete_form): array {
// Set icons for the options.
$element['#options'] = [$element['#empty_value'] => ''] + Select2Icon::loadIcons();
return $element;
Expand All @@ -25,7 +25,7 @@ public static function processSelect(&$element, FormStateInterface $form_state,
/**
* {@inheritdoc}
*/
public static function preRenderSelect($element) {
public static function preRenderSelect($element): array {
$element = parent::preRenderSelect($element);

// Set attributes to include the select2_icon library and settings.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function __construct($plugin_id, $plugin_definition, FieldDefinitionInter
/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition): static {
return new static(
$plugin_id,
$plugin_definition,
Expand All @@ -80,7 +80,7 @@ public static function create(ContainerInterface $container, array $configuratio
* @return array
* Returns array of elements.
*/
public function viewElements(FieldItemListInterface $items, $langcode) {
public function viewElements(FieldItemListInterface $items, $langcode): array {
$elements = [];

foreach ($items as $delta => $item) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class Select2Icon extends FieldItemBase {
/**
* {@inheritdoc}
*/
public static function propertyDefinitions(FieldStorageDefinitionInterface $storage) {
public static function propertyDefinitions(FieldStorageDefinitionInterface $storage): array {
$properties = [];
$properties['icon'] = DataDefinition::create('string')->setLabel(t('Icon ID'));
return $properties;
Expand All @@ -33,7 +33,7 @@ public static function propertyDefinitions(FieldStorageDefinitionInterface $stor
/**
* {@inheritdoc}
*/
public static function schema(FieldStorageDefinitionInterface $field_definition) {
public static function schema(FieldStorageDefinitionInterface $field_definition): array {
return [
'columns' => [
'icon' => [
Expand All @@ -47,7 +47,7 @@ public static function schema(FieldStorageDefinitionInterface $field_definition)
/**
* {@inheritdoc}
*/
public function isEmpty() {
public function isEmpty(): bool {
return empty($this->get('icon')->getValue());
}

Expand All @@ -60,7 +60,7 @@ public function isEmpty() {
* @return array
* Returns an array of icons or empty array.
*/
public static function loadIcons() : array {
public static function loadIcons(): array {
if ($icons = \Drupal::cache()->get(static::SELECT2_ICON_CACHE)) {
return $icons->data;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function __construct(string $plugin_id, $plugin_definition, FieldDefiniti
/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition): static {
return new static(
$plugin_id,
$plugin_definition,
Expand All @@ -70,7 +70,7 @@ public static function create(ContainerInterface $container, array $configuratio
/**
* {@inheritdoc}
*/
public function formElement(FieldItemListInterface $items, $delta, array $element, array &$form, FormStateInterface $form_state) {
public function formElement(FieldItemListInterface $items, $delta, array $element, array &$form, FormStateInterface $form_state): array {
$element['icon'] = [
'#type' => 'select2',
'#title' => $this->t('Icon'),
Expand All @@ -95,7 +95,7 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
* @return array
* The array of options for the widget.
*/
protected function getOptions(FieldableEntityInterface $entity) {
protected function getOptions(FieldableEntityInterface $entity): array {
if (!isset($this->options)) {
$this->options = Select2Icon::loadIcons();
}
Expand All @@ -111,7 +111,7 @@ protected function getOptions(FieldableEntityInterface $entity) {
* @return array
* The array of corresponding selected options.
*/
protected function getSelectedOptions(FieldItemListInterface $items) {
protected function getSelectedOptions(FieldItemListInterface $items): array {
// In case this widget is used for opt groups.
$flat_options = OptGroup::flattenOptions($this->getOptions($items->getEntity()));

Expand Down