Update ops/ntp/iosxe: "isconfigured" bool -> str#196
Open
jlmcgraw wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Open
Update ops/ntp/iosxe: "isconfigured" bool -> str#196jlmcgraw wants to merge 1 commit intoCiscoTestAutomation:mainfrom
jlmcgraw wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Conversation
jlmcgraw
commented
Nov 4, 2025
- isconfigured is a string, as in nxos
- Update test outputs to match
- isconfigured is a string, as in nxos - Update test outputs to match
ThomasJRyan
requested changes
Nov 5, 2025
| local_dict = self.info['vrf'][vrf]['associations']['address'][peer]\ | ||
| ['local_mode'][local_mode].setdefault('isconfigured', {}).\ | ||
| setdefault(isconfigured_value, {}) | ||
| setdefault(str(isconfigured_value), {}) |
Collaborator
There was a problem hiding this comment.
It's difficult to make this change... It's possible that someone out there is relying on this value being a boolean... If this is strictly necessary you might need to look into making a revision of the ops model
Author
|
I don't disagree, though I thought that the primary point of these models
was that they were consistent across devices and OSes?
That is how I came across this: I was expecting to be able to gather data
from disparate devices and OSes into identically laid out data structures
that I could then use to generate tests from, and that was failing for this
"isconfigured" key.
I can work around it but was imagining that it would be worth getting
aligned
If a revision is the way to go, is there a guide for how to do revisions
for an OPS model? I see one for parsers
<https://github.com/CiscoTestAutomation/getting-started/blob/fabea6b186dc06a9ec4c5af3d88b05ff4bd8d019/develop-guide/writeparser/writeparser.rst#8-revising-a-parser>
but
have not yet found one for models
…On Wed, Nov 5, 2025 at 9:54 AM Thomas Ryan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In pkgs/ops-pkg/src/genie/libs/ops/ntp/iosxe/ntp.py
<#196 (comment)>
:
> @@ -55,7 +55,7 @@ def set_defaults(self, peer, vrf):
local_dict = self.info['vrf'][vrf]['associations']['address'][peer]\
['local_mode'][local_mode].setdefault('isconfigured', {}).\
- setdefault(isconfigured_value, {})
+ setdefault(str(isconfigured_value), {})
It's difficult to make this change... It's possible that someone out there
is relying on this value being a boolean... If this is strictly necessary
you might need to look into making a revision of the ops model
—
Reply to this email directly, view it on GitHub
<#196 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2IJXXDG2Y6I6LXGPYOYGL33IFSLAVCNFSM6AAAAACLENFC76VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMRSGYYDSMJUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.