Skip to content

Update ops/ntp/iosxe: "isconfigured" bool -> str#196

Open
jlmcgraw wants to merge 1 commit intoCiscoTestAutomation:mainfrom
jlmcgraw:2025-11-04_cisco_ios_xe_learn_ntp
Open

Update ops/ntp/iosxe: "isconfigured" bool -> str#196
jlmcgraw wants to merge 1 commit intoCiscoTestAutomation:mainfrom
jlmcgraw:2025-11-04_cisco_ios_xe_learn_ntp

Conversation

@jlmcgraw
Copy link

@jlmcgraw jlmcgraw commented Nov 4, 2025

  • isconfigured is a string, as in nxos
  • Update test outputs to match

- isconfigured is a string, as in nxos
- Update test outputs to match
local_dict = self.info['vrf'][vrf]['associations']['address'][peer]\
['local_mode'][local_mode].setdefault('isconfigured', {}).\
setdefault(isconfigured_value, {})
setdefault(str(isconfigured_value), {})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to make this change... It's possible that someone out there is relying on this value being a boolean... If this is strictly necessary you might need to look into making a revision of the ops model

@jlmcgraw
Copy link
Author

jlmcgraw commented Nov 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants