Dropped PCL support for CML versions below 2.6.0 #156
Conversation
Pull Request Test Coverage Report for Build 11373068995Details
💛 - Coveralls |
|
|
||
| test: ## run tests quickly with the default Python | ||
| python -W ignore::DeprecationWarning setup.py test | ||
| pytest tests/v2/* |
There was a problem hiding this comment.
Changed both tests and coverage for compatibility with newer versions of some python modules such as setuptools, etc..
| return "Other Lab" | ||
|
|
||
| def get_cml23_id(self): | ||
| def get_cml24_id(self): |
There was a problem hiding this comment.
/virl2_client/models/lab.py:1463: DeprecationWarning: Labs created in older CML releases (schema version 0.0.5 or lower) are deprecated. Use labs with schema version 0.1.0 or higher.
warnings.warn(
I bumped test labs only to schema version 0.1.0 which was used in CML 2.4.0 to prevent the warning. Could be bumped to 2.6.0 or changes could be removed if there's any reason to prevent the support for 0.0.3 schema version.
| from unittest.mock import patch | ||
| except ImportError: | ||
| from mock import patch # noqa | ||
| from . import BaseCMLTest |
There was a problem hiding this comment.
The import was missing and everything else was removed due to dropped support for CML 2.3.
| @staticmethod | ||
| def get_sys_info(req, ctx=None): | ||
| response = {"version": "2.4.0+build.3", "ready": True} | ||
| response = {"version": "2.6.0+build.5", "ready": True} |
There was a problem hiding this comment.
We are going to drop support for CML releases below 2.6.0 in the next version of virl2 client (2.8.0).
xorrkaz
left a comment
xorrkaz
left a comment
There was a problem hiding this comment.
No objections to this, but can you add a blurb to the README's prereq that states CML 2.6.0+ is required?
Dropped topology support for versions below 0.1.0
3 participants
Dropped topology support for versions below 0.1.0