Skip to content

Conversation

@sgherdao
Copy link
Contributor

Hi Joe,

I have added the cml users and cml groups commands (with tests and docs). Also added some minor cleanups and improvements (isort, doc, .gitignore).

No rush to merge, feel free to play with it and I can adapt based on suggestions.

Tx

@coveralls
Copy link

coveralls commented Jun 22, 2024

Pull Request Test Coverage Report for Build 9621711667

Details

  • 372 of 396 (93.94%) changed or added relevant lines in 67 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 75.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
virl/cli/groups/ls/commands.py 19 20 95.0%
virl/cli/users/ls/commands.py 19 20 95.0%
virl/cli/views/groups/group_views.py 20 22 90.91%
virl/cli/views/users/user_views.py 22 24 91.67%
virl/cli/groups/delete/commands.py 18 21 85.71%
virl/cli/groups/update/commands.py 29 32 90.63%
virl/cli/users/create/commands.py 24 30 80.0%
virl/cli/users/update/commands.py 30 36 83.33%
Totals Coverage Status
Change from base Build 8772541850: 1.9%
Covered Lines: 1952
Relevant Lines: 2574

💛 - Coveralls

@xorrkaz xorrkaz merged commit b3bc0b8 into CiscoDevNet:joe-dev Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants