Skip to content

Conversation

@sgherdao
Copy link
Contributor

@sgherdao sgherdao commented Apr 14, 2024

Hi Joe,

A small enhancement PR to make the tables look a little bit more compact:

For lab, use textwrap to wrap the description and use lab.username instead of lab.owner (UUID).
For nodes, use the newline char instead of comma for IP addresses separator (see tabulate Mutline Cells).

Thanks,

Salah

For lab, use textwrap to wrap the description and use lab.username instead
of lab.owner (UUID).
For nodes, use the newline char instead of comma for IP addresses
separator (see tabulate Mutline Cells).
@coveralls
Copy link

coveralls commented Apr 14, 2024

Pull Request Test Coverage Report for Build 8693790128

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 73.955%

Files with Coverage Reduction New Missed Lines %
virl/api/cml.py 1 90.7%
Totals Coverage Status
Change from base Build 8383605821: 0.01%
Covered Lines: 1698
Relevant Lines: 2296

💛 - Coveralls

Copy link
Collaborator

@xorrkaz xorrkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I can't believe I stuck with the user ID for so long. A hold-over from CML 2.2 and before. Anyway, no good deed goes unpunished. I think it would be worth updating the doc examples for cml ls and cml nodes. Can you add that to this PR as well?

@sgherdao
Copy link
Contributor Author

That's the second worst punishment a dev could think of :).
README updated. I'm not sure if the shorter ID was mock generated or if this was because of a different CML version, but I decided to keep UUID even though they make the tables' width a bit long.

@sgherdao sgherdao requested a review from xorrkaz April 15, 2024 18:21
Copy link
Collaborator

@xorrkaz xorrkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xorrkaz xorrkaz merged commit 861536d into CiscoDevNet:joe-dev Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants