[minor_change] Migrate resource and datasource aci_vmm_credential to terraform plugin framework (DCNE-578) #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terraform plugin framework
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
gmicol
requested changes
Nov 18, 2025
gen/definitions/properties.yaml
Outdated
Comment on lines
2735
to
2736
| pwd: "The username of the %s object. This sensitive value is excluded from the resource's lifecycle configuration and is not tracked by Terraform." | ||
| usr: "The password of the %s object." |
Collaborator
There was a problem hiding this comment.
Suggested change
| pwd: "The username of the %s object. This sensitive value is excluded from the resource's lifecycle configuration and is not tracked by Terraform." | |
| usr: "The password of the %s object." | |
| pwd: "The password of the %s object. This sensitive value is excluded from the resource's lifecycle configuration and is not tracked by Terraform." | |
| usr: "The username of the %s object." |
lhercot
requested changes
Nov 18, 2025
docs/data-sources/vmm_credential.md
Outdated
| # Documentation generated by "gen/generator.go"; DO NOT EDIT. | ||
| # In order to regenerate this file execute `go generate` from the repository root. | ||
| # More details can be found in the [README](https://github.com/CiscoDevNet/terraform-provider-aci/blob/master/README.md). | ||
| subcategory: "Generic" |
Member
There was a problem hiding this comment.
Suggested change
| subcategory: "Generic" | |
| subcategory: "Virtual Networking" |
docs/resources/vmm_credential.md
Outdated
| # Documentation generated by "gen/generator.go"; DO NOT EDIT. | ||
| # In order to regenerate this file execute `go generate` from the repository root. | ||
| # More details can be found in the [README](https://github.com/CiscoDevNet/terraform-provider-aci/blob/master/README.md). | ||
| subcategory: "Generic" |
Member
There was a problem hiding this comment.
Suggested change
| subcategory: "Generic" | |
| subcategory: "Virtual Networking" |
… the documentation
akinross
force-pushed
the
vmm_credentials_migration
branch
from
6a9aa16 to
9e3955e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.