Python Part 3 tests #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annegentle
commented
Jan 15, 2021
| @@ -3,3 +3,4 @@ netmiko>=3.3.2 | |||
| pyyaml>=5.3.1 | |||
| requests>=2.25.1 | |||
| xmltodict>=0.12.0 | |||
| pysnmp>=4.4.12 | |||
There was a problem hiding this comment.
@hpreston I had to add pysnmp to the requirements.txt for the GitHub Actions check to pass and for it to run locally for me - can you make sure this is correct?
There was a problem hiding this comment.
@annegentle yeah that's right. I left if off because that particular script/library isn't covered in the video. But as the script is in the repo worth including the requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.