Clam 1651 #3 Fix leak loading malformed CFG database #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahsnyder
force-pushed
the
CLAM-1651-cfg
branch
from
0f88b7d
to
9234e98
Compare
|
Rebased to see it go through testing. |
micahsnyder
changed the title
micahsnyder
changed the title
micahsnyder
requested changes
May 29, 2022
libclamav/readdb.c
Outdated
| if (engine->bcs.all_bcs) { | ||
| for (i = 0; i < engine->bcs.count; i++) { | ||
| cli_bytecode_destroy(&engine->bcs.all_bcs[i]); | ||
| if (engine->dconf->bytecode & BYTECODE_ENGINE_MASK) { |
There was a problem hiding this comment.
I don't think this if-statement is needed.
Any changes here should be mirrored above where we do the tasks_to_do += stuff.
|
I pushed the suggested fixes myself, since it was hard to describe. |
micahsnyder
force-pushed
the
CLAM-1651-cfg
branch
from
479d885
to
720b67b
Compare
micahsnyder
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43813