Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove configuration from dotnet test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a GitHub Actions workflow to build, test, sign, and package the WPF desktop application as an MSIX, and adjusts project and code files to support theming, logging, and packaging.
- Add
.github/workflows/dotnet-desktop.ymlto automate build, test, and MSIX packaging. - Update
.csprojand resource files to include theme XAML dictionaries and demo boards data. - Refactor application startup (
App.xaml.cs), main window (MainWindow.xaml(.cs)), and introduceILoggerabstraction for unified logging.
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/dotnet-desktop.yml | New CI workflow for building, testing, and packaging |
| Solver/Solver.csproj | Include theme XAML as resources; configure demo boards |
| Solver/src/App.xaml.cs | Load and apply Light/Dark theme dictionaries at startup |
| Solver/src/App.xaml | Update merged dictionaries setup for dynamic theming |
| Solver/src/Resources/LightTheme.xaml | Define light-mode brushes |
| Solver/src/Resources/DarkTheme.xaml | Define dark-mode brushes |
| Solver/src/MainWindow.xaml | XAML tweaks for dynamic resources and layout |
| Solver/src/MainWindow.xaml.cs | Refactor status updates to use ILogger; demo boards |
| Solver/src/ILogger.cs | Define ILogger; add Logger and FileLogger |
| Solver/src/BoardSolution.cs | Add new BoardSolution class |
| Solver/src/DisplayableSolutionWord.cs | Add documentation comment |
| Solver/src/Configuration/ConfigurationService.cs | Expose AppName; configure default demo boards |
| Solver/src/Configuration/AppSettings.cs | Define theme and demo boards settings |
| Solver/src/AssemblyInfo.cs | Make internals visible to test project |
| Solver.Tests/WordFinderTests.cs | Add XML documentation to tests |
| Solver.Tests/Solver.Tests.csproj | New test project file |
| Solver.Tests/MockLogger.cs | Import Solver namespace for ILogger |
| README.md | Add overview, usage, and contribution instructions |
Comments suppressed due to low confidence (2)
Solver/src/BoardSolution.cs:1
- This file uses
List<T>andHashSet<T>but lacksusing System.Collections.Generic;, which will cause compilation errors. Add the appropriateusingdirective.
namespace Solver;
Solver/src/App.xaml.cs:35
- [nitpick] The pack URI uses
/src/Resources/…, but packaging may expect/Resources/…without thesrcfolder. Verify the resource path matches the output assembly structure.
string themeUriString = theme == AppTheme.Dark
| _filePath = filePath; | ||
| try | ||
| { | ||
| Directory.CreateDirectory(Path.GetDirectoryName(_filePath)); |
There was a problem hiding this comment.
Calling GetDirectoryName can return null (e.g., if path has no directory component), leading to ArgumentNullException. Add a null check before creating the directory.
Suggested change
| Directory.CreateDirectory(Path.GetDirectoryName(_filePath)); | |
| var directoryPath = Path.GetDirectoryName(_filePath); | |
| if (directoryPath != null) | |
| { | |
| Directory.CreateDirectory(directoryPath); | |
| } |
# Conflicts: # .gitignore # Solver.Tests/Solver.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add github workflow for building msix