Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SearchCondition visitor with improvements from SQL Server version #255

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

ChrisJollyAU
Copy link
Member

Following from the SQL Server part of EF Core, there has been multiple improvements and optimizations set up in the SearchConditionConvertingExpressionVisitor

Update this with those improvements

2 main ones to point out are dotnet/efcore#23711. This changes code from <> TRUE to = FALSE in certain cases

There is also numerous improvements under the heading of dotnet/efcore#34001

This mostly encompasses nullable boolean expressions not returning null. Optimizations/fixes include using bitwise XOR instead of the normal CASE expression (or in Jet since we don't have that we use the IF...THEN)

@ChrisJollyAU ChrisJollyAU added this to the 9.0.0 milestone Aug 24, 2024
@ChrisJollyAU ChrisJollyAU merged commit bf6e8a1 into CirrusRedOrg:master Aug 25, 2024
13 checks passed
@ChrisJollyAU ChrisJollyAU deleted the searchcondupdate branch August 25, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant