Skip to content

Conversation

ChrisJollyAU
Copy link
Member

Updates EF Core to 8.0.3

There is still some tests failing due to a change in the base test e.g. Can_apply_all_migrations

The base test now includes a string with new lines as part of the sql statement. It is part of a string literal direct from C# so there is not processing on it before hand. The test value is a property as part of a private class within the base class so can't just override it

INSERT INTO Table1 (Id, Bar, Description) VALUES (-1, ' ', 'Value With

Empty Lines')

@lauxjpn Thoughts?

@ChrisJollyAU ChrisJollyAU added this to the 8.0.0-beta.2 milestone Mar 13, 2024
@ChrisJollyAU ChrisJollyAU self-assigned this Mar 13, 2024
@lauxjpn
Copy link
Member

lauxjpn commented Mar 15, 2024

There are multiple issues with these tests at the moment. In Pomelo, we just hit dotnet/efcore#33331.

I would suggest to expect them to fail for now (as the SQL Server provider does), until they have been fixed.

@ChrisJollyAU
Copy link
Member Author

Thanks. Glad it wasn't just me.

Initially thought it was related to new lines in the string (in JetStringTypeMapping we do replace new lines with the respective CHR(10) and CHR(13) ) so thought it related to that.

However, after a bit of checking (error was only Data type mismatch in criteria expression which isn't always specific), it is actually the same issue (dotnet/efcore#33331 ) that you have in Pomelo

@ChrisJollyAU ChrisJollyAU merged commit 183a5b9 into CirrusRedOrg:master Mar 15, 2024
@ChrisJollyAU ChrisJollyAU deleted the efupdate branch March 15, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants