Skip to content

CI-994 - Remove check for ingest dataset when updating samplesheet #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanthorpe merged 3 commits into from
Dec 16, 2025
Merged

CI-994 - Remove check for ingest dataset when updating samplesheet #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e74938c
remove check for ingest dataset
nathanthorpe Dec 16, 2025
c570406
bump version
nathanthorpe Dec 16, 2025
8032dac
remove unused
nathanthorpe Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cirro/sdk/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from cirro_api_client.v1.api.processes import validate_file_requirements
from cirro_api_client.v1.models import Dataset, DatasetDetail, RunAnalysisRequest, ProcessDetail, Status, \
RunAnalysisRequestParams, Tag, ArtifactType, NamedItem, Executor, ValidateFileRequirementsRequest
RunAnalysisRequestParams, Tag, ArtifactType, NamedItem, ValidateFileRequirementsRequest

from cirro.cirro_client import CirroApi
from cirro.models.assets import DatasetAssets
Expand Down Expand Up @@ -328,9 +328,6 @@ def update_samplesheet(self,
if contents is None and file_path is None:
raise DataPortalInputError("Must specify either 'contents' or 'file_path' when updating samplesheet")

if self.process.executor != Executor.INGEST:
raise DataPortalInputError("Cannot update a samplesheet on a non-ingest dataset")

samplesheet_contents = contents
if file_path is not None:
samplesheet_contents = Path(file_path).expanduser().read_text()
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "cirro"
version = "1.9.2"
version = "1.9.3"
description = "CLI tool and SDK for interacting with the Cirro platform"
authors = ["Cirro Bio <support@cirro.bio>"]
license = "MIT"
Expand Down
Loading