Support more than 20,000 files on file listing #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanthorpe
changed the title
sminot
approved these changes
Jun 27, 2024
cirro/services/dataset.py
Outdated
| dataset_id: str, | ||
| download_location: str, | ||
| files: Union[List[File], List[str]] = None | ||
| self, |
| Args: | ||
| project_id (str): ID of the Project | ||
| dataset_id (str): ID of the Dataset | ||
| file_limit (int): Maximum number of files to get (default 100,000) |
Contributor
There was a problem hiding this comment.
Should probably add an informative error message if someone sets file_limit = 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI-114
Datasets can support more files now that the response is paginated. Update the SDK code to retrieve all files from a dataset, with an optional limit.