Skip to content

Improve file requirements messaging #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanthorpe merged 4 commits into from
Jun 26, 2024
Merged

Improve file requirements messaging #112

nathanthorpe merged 4 commits into from
Jun 26, 2024

Conversation

@nathanthorpe
Copy link
Contributor

@nathanthorpe nathanthorpe commented Jun 26, 2024 •
edited
Loading

CI-206

  • Display input errors as a message in the console, rather than a stacktrace
  • Improve error message when displaying file requirements
2024-06-26 12:33:01,018 INFO     [Cirro CLI] Validating expected files: 10X Single-Cell (FASTQ)
2024-06-26 12:33:01,176 ERROR    [Cirro CLI] The files you have provided are: test.fastq 

They do not meet the dataset requirements. The required file types are: 
Paired FASTQs (with associated index reads). At least 2 file(s) required. We accept any of the following naming conventions: 
        - SampleName_S1_L001_R1_001.fastq.gz
        - SampleName_S1_R1_001.fastq.gz

@nathanthorpe nathanthorpe requested a review from a team June 26, 2024 19:37
sminot
sminot approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@sminot sminot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nathanthorpe nathanthorpe merged commit e321e48 into main Jun 26, 2024
@nathanthorpe nathanthorpe deleted the file-requirements-messaging branch June 26, 2024 22:13
@mzager
Copy link
Contributor

mzager commented Jun 27, 2024 •
edited
Loading

lgtm

I read this and thought it meant 'let's go to market'. This looks good to me as well. Nice work!!!

Is file type one word or two?

@nathanthorpe
Copy link
Contributor Author

nathanthorpe commented Jun 27, 2024

two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sminot sminot sminot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nathanthorpe @mzager @sminot