Skip to content

Conversation

@Amalshaheen
Copy link

@Amalshaheen Amalshaheen commented Jan 23, 2026

Fixes #484

Describe the changes you have made in this PR:

This PR fixes Android build failures caused by outdated build configurations and deprecated settings. The changes ensure compatibility with the latest Flutter plugins and Android dependencies.

Changes made:

  1. settings.gradle - Upgraded Android Gradle Plugin from 8.7.0 to 8.9.1 (required by androidx.browser:1.9.0)
  2. settings.gradle - Upgraded Kotlin version from 1.9.25 to 2.1.0 (addressing Flutter deprecation warning)
  3. build.gradle - Updated compileSdk from 35 to 36 (required by multiple plugins including flutter_secure_storage, google_sign_in_android, etc.)
  4. build.gradle - Updated minSdkVersion from 21 to 24 (required by flutter_secure_storage)

Why these changes are necessary:

  • Multiple Flutter plugins (flutter_secure_storage, google_sign_in_android, webview_flutter_android, etc.) require Android SDK 36
  • androidx.browser:1.9.0 dependency mandates AGP 8.9.1+
  • Flutter officially warns that Kotlin 1.9.25 support will be dropped soon
  • flutter_secure_storage requires minimum API level 24

Screenshots of the changes (If any):
N/A - Configuration changes only, no UI changes

Testing:

  • Build completes successfully with flutter build apk
  • App runs without errors on Android emulator
  • No deprecation warnings in build output except for (synthetic-package) which is out of scope of the PR

Summary by CodeRabbit

  • Chores
    • Updated Android SDK targets: compileSdk -> 36, targetSdk -> 35, minSdk -> 24.
    • Upgraded Gradle wrapper to 8.11.1.
    • Bumped Android Gradle plugin and Kotlin plugin to newer versions.
    • Minor formatting cleanup (end-of-file newline).

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for cv-mobile-app-web ready!

Name Link
🔨 Latest commit aa08be9
🔍 Latest deploy log https://app.netlify.com/projects/cv-mobile-app-web/deploys/697aaca2bd507300088db5eb
😎 Deploy Preview https://deploy-preview-485--cv-mobile-app-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Walkthrough

This pull request updates Android build configuration: Android Gradle Plugin bumped to 8.9.1 in android/settings.gradle, Kotlin bumped to 2.1.0 in android/settings.gradle, Gradle wrapper updated to 8.11.1 in android/gradle/wrapper/gradle-wrapper.properties, compileSdk increased from 35 to 36, minSdkVersion increased from 23 to 24, and targetSdkVersion updated from 33 to 35 in android/app/build.gradle. A formatting change added a trailing newline in android/app/build.gradle.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: upgrading AGP to 8.9.1, Kotlin to 2.1.0, and Android SDK (compileSdk) to 36. It is concise, specific, and directly reflects the primary modifications in the changeset.
Linked Issues check ✅ Passed All primary coding requirements from issue #484 are met: AGP upgraded to 8.9.1 [#484], Kotlin upgraded to 2.1.0 [#484], compileSdk updated to 36 [#484], and minSdkVersion updated to 24 [#484]. The targetSdkVersion update to 35 is an additional enhancement.
Out of Scope Changes check ✅ Passed All changes in the PR are directly aligned with resolving the build failure issue #484. The gradle wrapper update and file formatting changes are reasonable maintenance tasks supporting the primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@android/app/build.gradle`:
- Around line 76-77: The Android manifest/build config currently sets
targetSdkVersion 33; update targetSdkVersion to 35 (or at minimum 34) in the
android/app/build.gradle defaultConfig (replace targetSdkVersion 33 with 35) to
meet Google Play requirements, and ensure compileSdkVersion in the same Gradle
module is >= the new target (update compileSdkVersion if necessary); keep the
existing minSdkVersion 24 as-is.

In `@android/settings.gradle`:
- Around line 21-22: The plugin version bumps for "com.android.application" to
8.9.1 and "org.jetbrains.kotlin.android" to 2.1.0 should not be merged yet:
verify compatibility by (1) confirming androidx.browser:1.9.0 does not require a
higher AGP (if it needs compileSdk 36 or an alpha that requires AGP 8.13+, hold
or pin to a compatible browser/artifact), (2) running a full clean build and CI
test matrix to catch Kotlin 2.1 K2 breaking changes (check compilation errors
from the K2 compiler, inaccessible-type errors, private operator usage, locale
APIs, and deprecated KGP IDs), and (3) if breakages appear, either revert the
Kotlin plugin bump in settings (keep org.jetbrains.kotlin.android at the
previous stable version) or perform code fixes/migrations and enable any
required Kotlin compiler flags before approving; ensure you reference and test
the two plugin IDs ("com.android.application" and
"org.jetbrains.kotlin.android") in local and CI builds and update project
documentation about the required AGP/Kotlin minimums.

@ShashwatXD
Copy link
Contributor

@Amalshaheen you have tests failing please fix this.

@Amalshaheen Amalshaheen force-pushed the fix-android-dependancy-issue branch from 0810a13 to 56afd9e Compare January 29, 2026 00:33
@Amalshaheen
Copy link
Author

@Amalshaheen you have tests failing please fix this.

@ShashwatXD Done, Could you review when you're free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android build failure: Dependencies require AGP 8.9.1+, compileSdk 36, minSdk 24, and Kotlin 2.1.0+

2 participants