-
Notifications
You must be signed in to change notification settings - Fork 131
Upgrade AGP to 8.9.1, Kotlin to 2.1.0, and Android SDK to 36 #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade AGP to 8.9.1, Kotlin to 2.1.0, and Android SDK to 36 #485
Conversation
✅ Deploy Preview for cv-mobile-app-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis pull request updates Android build configuration: Android Gradle Plugin bumped to 8.9.1 in Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@android/app/build.gradle`:
- Around line 76-77: The Android manifest/build config currently sets
targetSdkVersion 33; update targetSdkVersion to 35 (or at minimum 34) in the
android/app/build.gradle defaultConfig (replace targetSdkVersion 33 with 35) to
meet Google Play requirements, and ensure compileSdkVersion in the same Gradle
module is >= the new target (update compileSdkVersion if necessary); keep the
existing minSdkVersion 24 as-is.
In `@android/settings.gradle`:
- Around line 21-22: The plugin version bumps for "com.android.application" to
8.9.1 and "org.jetbrains.kotlin.android" to 2.1.0 should not be merged yet:
verify compatibility by (1) confirming androidx.browser:1.9.0 does not require a
higher AGP (if it needs compileSdk 36 or an alpha that requires AGP 8.13+, hold
or pin to a compatible browser/artifact), (2) running a full clean build and CI
test matrix to catch Kotlin 2.1 K2 breaking changes (check compilation errors
from the K2 compiler, inaccessible-type errors, private operator usage, locale
APIs, and deprecated KGP IDs), and (3) if breakages appear, either revert the
Kotlin plugin bump in settings (keep org.jetbrains.kotlin.android at the
previous stable version) or perform code fixes/migrations and enable any
required Kotlin compiler flags before approving; ensure you reference and test
the two plugin IDs ("com.android.application" and
"org.jetbrains.kotlin.android") in local and CI builds and update project
documentation about the required AGP/Kotlin minimums.
|
@Amalshaheen you have tests failing please fix this. |
0810a13 to
56afd9e
Compare
@ShashwatXD Done, Could you review when you're free |
Fixes #484
Describe the changes you have made in this PR:
This PR fixes Android build failures caused by outdated build configurations and deprecated settings. The changes ensure compatibility with the latest Flutter plugins and Android dependencies.
Changes made:
compileSdkfrom 35 to 36 (required by multiple plugins including flutter_secure_storage, google_sign_in_android, etc.)minSdkVersionfrom 21 to 24 (required by flutter_secure_storage)Why these changes are necessary:
Screenshots of the changes (If any):
N/A - Configuration changes only, no UI changes
Testing:
flutter build apksynthetic-package) which is out of scope of the PRSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.