-
Notifications
You must be signed in to change notification settings - Fork 131
chore(deps): align SDK constraints and README with dependencies #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(deps): align SDK constraints and README with dependencies #479
Conversation
✅ Deploy Preview for cv-mobile-app-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe README.md was edited to update the listed prerequisites from Flutter 3.32.2 (Dart 3.8.1) to Flutter 3.35.0 (Dart 3.9.0) and minor formatting around the Android OAuth Config text. The pubspec.yaml environment SDK constraint was changed from ">=3.7.2 <4.0.0" to ">=3.9.0 <4.0.0". No other dependency, public API, or behavioral changes were made. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
49-49: Stale Flutter version reference.Line 49 still references "Flutter 3.32.2" while the prerequisites now require Flutter 3.35.0. This inconsistency could confuse contributors.
📝 Suggested fix
-This project uses Flutter 3.32.2 and hence the support for compile-time variables. To use compile-time variables pass them in `--dart-defines` as `flutter run --dart-define=VAR_NAME=VAR_VALUE`. Supported `dart-defines` include : +This project uses Flutter 3.35.0 and hence the support for compile-time variables. To use compile-time variables pass them in `--dart-defines` as `flutter run --dart-define=VAR_NAME=VAR_VALUE`. Supported `dart-defines` include :
🤖 Fix all issues with AI agents
In @README.md:
- Around line 14-15: In the README's Android OAuth Config section update the
outdated version token "Flutter 3.32.2" to "Flutter 3.35.0" so the prereqs match
the top-of-file Flutter/Dart versions; search for the literal string "Flutter
3.32.2" in the Android OAuth Config paragraph and replace it with "Flutter
3.35.0" (also fix the accidental "Flask" mention to "Flutter" if present).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
README.mdpubspec.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - cv-mobile-app-web
- GitHub Check: Header rules - cv-mobile-app-web
- GitHub Check: Pages changed - cv-mobile-app-web
🔇 Additional comments (1)
pubspec.yaml (1)
17-18: LGTM! SDK constraint correctly aligned with dependency requirements.The updated constraint
>=3.9.0 <4.0.0properly satisfies the shared_preferences ^2.5.4 requirement (line 54) and should resolve the dependency resolution failures for new contributors.
a3eff8f to
9710e62
Compare
9710e62 to
2fba297
Compare
Fixes #478
Describe the changes you have made in this PR -
This PR resolves
flutter pub getfailed for new contributors following the readme instructions.Documentation Update: Updated the README.md prerequisites to recommend Flutter ≥ 3.35.0 and Dart ≥ 3.9.0 to match the new project requirements.
Onboarding Fix: Ensures new developers can successfully resolve dependencies and build the app without "forbidden version" errors during their initial local environment setup.
Screenshots of the changes (If any) -null
Note: Please check Allow edits from maintainers. If you would like us to assist with the PR.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.