Terms of service button fix #335
Conversation
WalkthroughThe changes adjust the layout and styling of the Terms of Service and Privacy Policy buttons in the About view. The vertical margin around the container has been reduced, and each button is now wrapped in horizontal padding. Additionally, the buttons have been updated to use the small variant of the primary button widget by removing the Changes
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/ui/views/about/about_view.dart (1)
33-61: Consider using CVPrimaryButton.small factory method.The custom styling you've implemented for both buttons (font size 14, vertical padding) is similar to what's already available in the
CVPrimaryButton.smallfactory method defined in the component class.- child: CVPrimaryButton( - title: AppLocalizations.of(context)!.terms_of_service, - isBodyText: true, - padding: const EdgeInsets.symmetric(vertical: 12), - textStyle: Theme.of(context).textTheme.bodyLarge?.copyWith( - color: Colors.white, - fontSize: 14, - ), - onPressed: () => Get.toNamed(AboutTosView.id), - ), + child: CVPrimaryButton.small( + title: AppLocalizations.of(context)!.terms_of_service, + onPressed: () => Get.toNamed(AboutTosView.id), + ),Same refactoring could be applied to the Privacy Policy button. This would make the code more maintainable and consistent with the component's design patterns.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
lib/ui/components/cv_primary_button.dart(1 hunks)lib/ui/views/about/about_view.dart(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (windows-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (macos-latest)
🔇 Additional comments (4)
lib/ui/components/cv_primary_button.dart (1)
64-64: Newline added at the end of the file - good practice.Adding a newline character at the end of the file follows best practices for code formatting.
lib/ui/views/about/about_view.dart (3)
29-29: Improved vertical spacing for better layout.Reducing the vertical margin from 32 to 12 helps create a more compact and visually balanced layout.
33-45: Good text overflow fix for Terms of Service button.The changes improve the button layout by:
- Adding horizontal padding for better spacing
- Setting explicit vertical padding for consistent height
- Using a smaller font size (14px) to prevent text overflow
These changes effectively address the text overflow issue mentioned in PR #332.
49-61: Good text overflow fix for Privacy Policy button.The changes mirror those made to the Terms of Service button, ensuring consistent styling and layout between both buttons while preventing text overflow.
Pull Request Test Coverage Report for Build 14284185934Details
💛 - Coveralls |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
Fixes #
Fixed the issue number: #332
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Before:
After:
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit