Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clap to CLI #36

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add Clap to CLI #36

wants to merge 1 commit into from

Conversation

Gers2017
Copy link

Hi everyone, I've made some changes that I hope will improve the CLI experience.
I'm open to feedback or suggestions.

  • Add clap to parse the command line arguments
    • It adds clap to the root directory since the CLI is under the bin directory.
    • If this is an issue, then I could move the CLI into it's own workspace and consume the crate as a library.

I've tested the CLI and I haven't encountered any problems. However I'd like to hear your feedback on the argument descriptions.
If necessary I'd be happy to change it.

@Gers2017 Gers2017 force-pushed the patch branch 2 times, most recently from 2b106e1 to 5f26171 Compare April 23, 2023 05:21
@louilinn
Copy link

@Gers2017 are you yourself using the CLI?
Sorry for taking so long to respond, currently we don't have a repo maintainer

@Gers2017
Copy link
Author

@louilinn Yes, I used the cli for some tests. Since this isn't a critical feature, feel free to close the pull request.

@louilinn
Copy link

louilinn commented Jun 15, 2023

Thanks for your reply! We very much appreciate your contribution. However we have a pending update in which the CLI was not prioritized to be maintained an therefore we might close this PR. If you are still using the CLI let us know and we can take it into consideration in our development work

@llunaCreixent
Copy link
Member

I will test your PR because we actually need the CLI for our staging environment :)

@benjaminbollen benjaminbollen self-assigned this Oct 17, 2023
@benjaminbollen
Copy link
Member

Hey @Gers2017 thanks for your PR,

I recently joined as new maintainer of the pathfinder and related code bases and I had a quick look already to your PR, it looks great.

As it has been sitting here for a while, I'm sure you have moved on since, but wanted to thank you nonetheless. I added it to the board and will come back to it proper.

thanks already,
Ben-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants