Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20240417 base58 shortnames; resolve IPFS metadata #145

Merged
merged 22 commits into from
May 10, 2024
Merged

20240417 base58 shortnames; resolve IPFS metadata #145

merged 22 commits into from
May 10, 2024

Conversation

benjaminbollen
Copy link
Member

re-opening #144 against develop

benjaminbollen and others added 22 commits April 10, 2024 12:31
@benjaminbollen
(deploy): update version number
e81a9b1
@benjaminbollen
(ERC1155): add total supply to mint paths; also name() and symbol()
f853e96
@benjaminbollen
(Circles): update mint and burn for total supply
98b0a36
@benjaminbollen
(changelog): update changelog
7b78c74
@benjaminbollen
(deploy): deployed version to chiado for testing
553a81c
@benjaminbollen
Merge branch '20240410-totalsupply-name-erc1155' into feature-v0.3.4
2365942
@benjaminbollen
Merge branch '20240412-operate-flow-reentrency-guard' into feature-v0…
bbcf0ca 
….3.4
@benjaminbollen
Merge branch '20240412-consented-flow' into feature-v0.3.4
4f2b439
@benjaminbollen
(circles): forge fmt
288be7a
@benjaminbollen
(hub): merging all open 0.3.4 PRs and fixing total build size
4030508
@benjaminbollen
(hub): assert that transient storage builds with solc, but not with f…
23778d8 
…orge
@benjaminbollen
Merge branch 'feature-v0.3.4' into 20240416-fitting-034-together
5f174c5
@benjaminbollen
(hub): forge fmt
cafe074
@benjaminbollen
(hub, nameRegistry): impl IPFS uri for erc1155, with fallback to cons…
727a45a 
…tant
@benjaminbollen
(hub): make private values that can be read from verification constru…
783b4a5 
…ctor to reduce build space
@benjaminbollen
(nameRegistry): refactor for better internal fcts; preparation to mak…
d82a290 
…e MockNameRegistry for tests avoiding Hubv2
@benjaminbollen
(test/names): cutting short effort to handle decoding base58 in tests
d9b07ac
@benjaminbollen
(NameRegistry): simplify to metadata digest storage, test short names
53a796c
@benjaminbollen
(NameRegistry): test base58 conversion for short names
b818894
@benjaminbollen
(NameRegistry): short names should always be padded to 12 characters
76fc410
@benjaminbollen
Merge branch 'develop' into 20240417-uri-with-ipfsv0
4d92020
@benjaminbollen
(test/names): remove unused base58 decoder
b37a433
@benjaminbollen benjaminbollen mentioned this pull request May 3, 2024
Closed
4 tasks
jaensen
jaensen approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaensen jaensen merged commit 4c0d5a5 into develop May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaensen jaensen jaensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
circles-contracts-v2
Status: 💪Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminbollen @jaensen