Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.1 #138

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Add PHP8.1 #138

merged 4 commits into from
Dec 13, 2021

Conversation

hrs-o
Copy link
Contributor

@hrs-o hrs-o commented Dec 1, 2021

I'm not a maintainer, but is this the way to make a pull request?
I have my PHP 8.1 project CI'd using the generated image.

  • The command I ran
    $ bash ./shared/gen-dockerfiles.sh 8.1.0

`$ bash ./shared/gen-dockerfiles.sh 8.1.0`
@hrs-o hrs-o requested review from FelicianoTech and a team as code owners December 1, 2021 08:25
@damcou
Copy link

damcou commented Dec 2, 2021

Hello, any ETA for the release of the 8.1 image ?

Thanks in advance.

@BytesGuy
Copy link
Contributor

BytesGuy commented Dec 2, 2021

Hello 👋 Thanks for opening this PR. We are aware of PHP 8.1 and this is currently prioritised behind work being carried out on #126 to ensure the images are stable and contain all the tooling that users require.

@FelicianoTech Can you follow up with a review on this PR when possible? Thanks!

@FelicianoTech
Copy link
Contributor

FelicianoTech commented Dec 13, 2021

A small change needs to be made (due to a conflict) which I'm doing now. Otherwise this will be merged shortly.

@FelicianoTech FelicianoTech merged commit 2fd3907 into CircleCI-Public:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants