Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator class #37

Merged
merged 4 commits into from
May 29, 2023
Merged

Simulator class #37

merged 4 commits into from
May 29, 2023

Conversation

ConnorStoneAstro
Copy link
Member

Adds subclass of Parametrized which defines a simulator object. This defines a behaviour for the __call__ method to handle parameter packing then pass to a user defined forward method.

@ConnorStoneAstro ConnorStoneAstro added the enhancement New feature or request label May 9, 2023
Copy link
Member Author

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is pretty basic

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #37 (b32e4c0) into main (1e386d7) will decrease coverage by 0.30%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   74.72%   74.42%   -0.30%     
==========================================
  Files          29       30       +1     
  Lines        1171     1177       +6     
==========================================
+ Hits          875      876       +1     
- Misses        296      301       +5     
Impacted Files Coverage Δ
src/caustic/packed.py 100.00% <ø> (ø)
src/caustic/simulator.py 0.00% <0.00%> (ø)
src/caustic/lenses/base.py 47.56% <33.33%> (+0.64%) ⬆️
src/caustic/lenses/utils.py 61.53% <40.00%> (ø)
src/caustic/parametrized.py 68.07% <100.00%> (ø)

@ConnorStoneAstro ConnorStoneAstro marked this pull request as ready for review May 10, 2023 03:08
src/caustic/parametrized.py Outdated Show resolved Hide resolved
@ConnorStoneAstro ConnorStoneAstro merged commit 8b63f29 into main May 29, 2023
@ConnorStoneAstro ConnorStoneAstro deleted the simulatorclass branch May 29, 2023 18:28
ConnorStoneAstro pushed a commit that referenced this pull request Dec 12, 2023
* style: Add codespace whitelist and perform spell check (#34)

* style: Update line length config and fix E501 errors (#35)

* style: Fix eof line .codespell-whitelist

* style: Remove * imports, fixes F403 PEP violation (#36)

* style: Expand imports for data module

* style: Fix undefined variables (F821), etc. (#37)

* style: Update pre-commit hooks and last lintings (#38)

* style: Revert Doubt to Dout (#39)

* style: Lint fix _config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants