Skip to content

Basic ssp dev #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
AlexaVillaume wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

Basic ssp dev #37

AlexaVillaume wants to merge 48 commits into from

Conversation

@AlexaVillaume
Copy link
Collaborator

@AlexaVillaume AlexaVillaume commented Nov 25, 2023

No description provided.

@AlexaVillaume
not sure at this point how to organize everything but just for the sa…
bdcd3b5 
…ke of getting started...
@AlexaVillaume
fixing a small issue with getting data_path
af1f5b1
@AlexaVillaume
fixing a small issue with getting data_path
b470e88
@AlexaVillaume
renaming to be more informative
9a44b80
@AlexaVillaume
whoops...this is why the renaming necessary
42216fa
@AlexaVillaume
need some safeguards wrt coverage between the isochrones and the stel…
adb101a 
…lar libaries
@AlexaVillaume
making progress on getting MLCRs, including fixing SSP synthesis
a7f889b
@AlexaVillaume
adding salpeter imf to help troubleshoot and to help figure out where…
c264505 
… the imf weight and normalization functions should go for the purposes of getting m2l
@AlexaVillaume
getting salpeter imf working
70fd5db
@AlexaVillaume
adding to the normalization functionality in the abstract IMF class
47f52ad
@AlexaVillaume
adding unit test for imf normalization
f3d4d8d
@AlexaVillaume
the wonders of unit tests
36355a8
@AlexaVillaume
added class for abritary two slope powerlawe IMF
f15e04d
@AlexaVillaume
mostly just refactoring the forward function to make it easier for me…
69880e3 
… to debug
@AlexaVillaume
small changes
5e3adba
@AlexaVillaume
leaving this to fix mist isochrone issue
522c0ef
@AlexaVillaume
Wondering if the error I'm getting with some of the isochrones, e.g.,…
01ad142 
… S.isochrone_grid.metallicities == -0.50, is the same problem Connor is seeing when running the test_isochrone unit test
@AlexaVillaume
should not be making selections based on anything other than age at t…
37de906 
…he point of getting the grid constructed
@AlexaVillaume
Now that I have a clearer understanding of nature of the problem -- s…
ea875dd 
…omething is wrong with how we're constructing the isochrone andor selecting a given isochrone from the grid -- I am creating a new notebook to dig into this issue specificially
@AlexaVillaume
at the very least the selection by metalliicity is wrong in get_isoch…
9ec205f 
…rone ><
@AlexaVillaume
close but no cigar selecting on both metallicity AS WELL AS age...but…
9726b68 
… progress
@AlexaVillaume
the issues with the determining the metallicity and age indices does …
5773c3d 
…not preclude some other problem in the creation of the grid itself. See how nothing comes back for age 10.1, 10.2, 10.3
@AlexaVillaume
There is indeed a serious bug in the construction of the isochrone gr…
785e37a 
…ide in get_isochrones.py
@AlexaVillaume
making progress fixing the bugs, something still not right about the …
5e43c31 
…age indexing
@AlexaVillaume
several bug fixes involving indexing, data typing, and some float iss…
0afb706 
…ues all in regards to fixing the isochrone selection
@AlexaVillaume
checking full ssp synthesis in light of the bug fixes I made to the i…
dbf0ecd 
…sochrone grid and isochrone selection...hopefully now I will have an easier time debugging the this now that the isochrones should at least be correct
@AlexaVillaume
introducing the use of a lighthouse environment variable in the hopes…
76367f2 
… that it will make establishing paths less of of a headache
@AlexaVillaume
trying to find all instances where environment variable should be used
425825b
@AlexaVillaume
trying to find all instances where environment variable should be used
ed73aa9
@AlexaVillaume
added unit test for enviornment variable
fbc3104
AlexaVillaume and others added 18 commits November 22, 2023 17:00
@AlexaVillaume
using environment variable
a3ae6f0
@AlexaVillaume
misplaced forward slash
f87806b
@AlexaVillaume
think this is the last of directory_path variales that need to be rep…
36e0990 
…laced
@AlexaVillaume
fixed all the path stuff st I can delete the notebooks from this repo…
c7506d1 
… and run them from light-house-analyses
@AlexaVillaume
Merge branch 'main' into isochrone_dev
308d6e7
@AlexaVillaume
cleaned up the function a bit
b48ef9f
@AlexaVillaume
the normalization constant is a property of the form of the IMF alone
9fc441a
@AlexaVillaume
refactoring the Basic_SSP class to help make the whole development pr…
5dd697d 
…ocees much less painfull
@AlexaVillaume
refactoring Basic_SSP class in light of issues that came up while deb…
cca0633 
…ugging the IMF weights
@AlexaVillaume
found the reason for the discrepancy in the spectral unitsgit status …
e34d809 
…fixed
@AlexaVillaume
adding phase selection back in
d3a6be2
@AlexaVillaume
finally getting around to fixing the retrieval of the stellar atmosph…
d7eac3f 
…ere spectra
@AlexaVillaume
small fixes to convert variables to torch datatypes
8c4df1b
@AlexaVillaume
added lower and upper mass limits in get_isochrone
2d92203
@AlexaVillaume
isochrone retrieval bug fixes
424651f
@AlexaVillaume
changes to go with verify_ssps notebook
d35bb7e
@AlexaVillaume
finally found the source of the normalization bug
2da5cea
@AlexaVillaume
pushing everything else because now the Kroupa and Salpeter SSPs in L…
3d54339 
…H are remarkably consistent with alf whoohoo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexaVillaume