Create Sunday School Class Group #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DawoudIO
commented
Sep 5, 2016
•
DawoudIO
commented
- Closes SundaySchool: Default Roles is Member #469
- Closes SundaySchool: Create requires lots of clicks #470
- Ensure it has the correct Roles
- Ensure it has the correct default role.
| <script type="application/javascript"> | ||
| $(document).ready(function () { | ||
|
|
||
| $("#addNewCalssBtn").click(function (e) { |
- url encode name - return jason data - redirect to the new class
|
@crossan007 this is ready |
crossan007
reviewed
Oct 4, 2016
| </div> | ||
| <div class="box-body"> | ||
| <?php if ($_SESSION['bManageGroups']) { ?> | ||
| <a href="SelectList.php?mode=person" class="btn btn-app" href="#" data-toggle="modal" data-target="#add-class"><i class="fa fa-plus-square"></i><?= gettext("Add New Class") ?></a> |
There was a problem hiding this comment.
Methinks you didn't mean to have this as an HREF href="SelectList.php?mode=person"
|
@DawoudIO If you're happy with my changes to this, then go ahead and merge it. |
DawoudIO
commented
Oct 4, 2016
| }).done(function (data) { //yippie, we got something good back from the server | ||
| ssClass = JSON.parse(data); | ||
| window.location.href = window.CRM.root + "/sundayschool/SundaySchoolClassView.php?groupId="+ ssClass["Id"]; | ||
| window.location.href = window.CRM.root + "/sundayschool/SundaySchoolClassView.php?groupId="+ data.Id; |
There was a problem hiding this comment.
that never worked for me...
DawoudIO
commented
Oct 4, 2016
| { | ||
| $group->makeSundaySchool(); | ||
| } | ||
| $group->setName($groupSettings->groupName); | ||
| $group->save(); | ||
| echo $group->toJSON(); |
There was a problem hiding this comment.
What is the diff between echo vs $group->toJSON() // which I don't see in our auto complete
return $response->withJson($group->exportTo("JSON"));
There was a problem hiding this comment.
Not sure. I've used the echo ->toJSON() everywhere up to this point, and it seems to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.