Self Registration #935

DawoudIO · 2016-08-26T12:07:33Z

Closes Add Self-Registration Feature #894

crossan007 · 2016-09-02T01:34:14Z

src/Service/SystemService.php

@@ -353,4 +354,8 @@ function reportIssue($data)
    return $result;
  }

+  function getConfig($configName) {


I think we should gradually kill off this function. Just call the ORM directly where we need to access config values.

I see no value in abstracting the ORM through SystemService.

I don't think it should be part of this PR though - see #963

crossan007 · 2016-10-20T23:48:15Z

The registration form is missing the Zip Code..

crossan007 · 2016-10-20T23:49:26Z

Country Field should be a dropdown

crossan007 · 2016-10-20T23:52:44Z

Fatal error: Class 'GoogleMapAPI' not found in /var/www/public/Include/GeoCoder.php on line 22

Occurs on http://192.168.33.10/FamilyView.php?FamilyID=1

crossan007 · 2016-10-20T23:54:45Z

src/Service/TimelineService.php

-        $displayEditedBy = $editor->getFullName();
+      $displayEditedBy = gettext("Unknown");
+      if ($dbNote->getDisplayEditedBy() == "-1") {
+        $displayEditedBy = gettext("Self Registration");


My self-entered families still show as unknown:

Correct, i could not find out how to make it show self registration or do we make it the head of the family etc...

crossan007 · 2016-10-20T23:57:53Z

Why does a member's birthday show up in PersonView.php

crossan007 · 2016-10-20T23:58:34Z

Fatal error: Call to a member function getBooleanValue() on null in /var/www/public/Login.php on line 273

on
http://192.168.33.10/Login.php?Logoff=True When logging into a restored 2.2.4 database

crossan007 · 2016-10-21T00:03:33Z

src/mysql/upgrade/2.3.0.sql

@@ -33,7 +33,8 @@ where `cfg_id` = 1037;
 delete from config_cfg where cfg_id ='18';
 delete from config_cfg where cfg_id ='2001';

-INSERT INTO `config_cfg` (`cfg_id`, `cfg_name`, `cfg_value`, `cfg_type`, `cfg_default`, `cfg_tooltip`, `cfg_section`, `cfg_category`) VALUES
+INSERT INTO `config_cfg` (`cfg_id`, `cfg_name`, `cfg_value`, `cfg_type`, `cfg_default`, `cfg_tooltip`, `cfg_section`, `cfg_category`, `cfg_data`) VALUES


Syntax error:

Executed successfully in 0.008 s, 0 rows affected. Line 1, column 1 Error code 1060, SQL state 42S21: Duplicate column name 'cfg_data' Line 4, column 1 Executed successfully in 0.004 s, 1 rows affected. Line 8, column 1 Executed successfully in 0.001 s, 1 rows affected. Line 13, column 1 Executed successfully in 0 s, 1 rows affected. Line 18, column 1 Executed successfully in 0.001 s, 1 rows affected. Line 23, column 1 Executed successfully in 0.001 s, 1 rows affected. Line 28, column 1 Executed successfully in 0.001 s, 0 rows affected. Line 33, column 1 Executed successfully in 0.001 s, 0 rows affected. Line 34, column 1 Error code 1136, SQL state 21S01: Column count doesn't match value count at row 2 Line 36, column 1 Executed successfully in 0 s, 0 rows affected. Line 47, column 1 Executed successfully in 0.001 s, 0 rows affected. Line 48, column 1 Executed successfully in 0.001 s, 0 rows affected. Line 49, column 1 Execution finished after 0.019 s, 2 error(s) occurred.

ya looks like a bad merge fixed

crossan007 · 2016-10-21T00:09:59Z

src/external/routes/register.php

+      $family->setState($body["familyState"]);
+      $family->setCountry($body["familyCountry"]);
+      $family->setHomePhone($body["familyHomePhone"]);
+      $family->setEnteredBy(0);


Did you mean for this to be -1 for timeline service to know it was self-registered?

yep but it never set -1 in the db not sure why

it has to do with

unsigned flag on the column

i got it to save to db but still not loading in the UI right... late work tonight

crossan007 · 2016-10-21T00:10:36Z

src/external/routes/register.php

+      $family->setDateEntered(new \DateTime());
+      $family->save();
+
+      $className = "Regular Attender";


The user is allowed to change these classes - we need to handle that somehow

yes in the next version, maybe still in 2.3 i want to use some of the defaults in the setting like default City, Country etc #1167 will track this

google Map is not a valid class

to support -1 as self regestration

crossan007 · 2016-10-22T18:10:29Z

src/external/routes/register.php

@@ -79,7 +79,6 @@
      }

      $birthday = $body["memberBirthday-" . $x];
-      $person->setTitle($birthday);


:-) hah. This was kind of a funny bug.

crossan007 · 2016-10-22T18:13:38Z

src/mysql/install/Install.sql

@@ -756,7 +756,7 @@ CREATE TABLE `note_nte` (
  `nte_Text` text,
  `nte_DateEntered` datetime NOT NULL default '0000-00-00 00:00:00',
  `nte_DateLastEdited` datetime default NULL,
-  `nte_EnteredBy` mediumint(8) unsigned NOT NULL default '0',
+  `nte_EnteredBy` mediumint(8) NOT NULL default '0',


why are you using smallint(5) in the fam table, and mediumint(8) in the note table?

DawoudIO added 10 commits August 22, 2016 18:51

setup for external site.

e1f3090

added missing sRootPath

47c9985

more framework setup

d4d2b53

added user pages

8fb6029

placeholders

90831d8

fixed spelling

73c4a93

2.0.0 RC2

bbfec91

merge dev

ef1289b

added gettext

e08ba93

family form created

b20e275

DawoudIO added the enhancement label Aug 26, 2016

DawoudIO added this to the 2.2.0 milestone Aug 26, 2016

DawoudIO added the In Review label Aug 26, 2016

DawoudIO added 4 commits August 26, 2016 05:13

fixed name

fd5005f

added error handling

53b007d

passing date from family form 1 to form 2

79ccdfc

create a family object and store it in the seesion

97bda25

DawoudIO added the do not merge! label Aug 27, 2016

DawoudIO mentioned this pull request Aug 27, 2016

Add Self-Registration Feature #894

Closed

DawoudIO and others added 7 commits August 31, 2016 16:17

merge develop

bf8220b

Disable Self Registration / Verification by default

49d90ac

get Config by name

bf27c05

check self registration setting before offering the feature

60f9db7

forms are now complete

5f4e612

extra html

fd16b3b

Merge branch 'develop' into external-mvc-site

7eff64a

crossan007 reviewed Sep 2, 2016
View reviewed changes

crossan007 closed this Oct 20, 2016

crossan007 reopened this Oct 20, 2016

crossan007 added In Review and removed In Review labels Oct 20, 2016

crossan007 reviewed Oct 20, 2016

View reviewed changes

crossan007 reviewed Oct 21, 2016

View reviewed changes

crossan007 added the please address comments label Oct 21, 2016

crossan007 assigned DawoudIO Oct 21, 2016

crossan007 reviewed Oct 21, 2016

View reviewed changes

DawoudIO added 9 commits October 21, 2016 07:18

fresh install has self regestration disabled

c6f66d8

cleanner class auto-loading

d191958

removed setting title as birthday

bfc471e

removed unset colummns to ensure we don't have a missmatch

8171698

added missing zip code

20ab8c1

reverted to old way of require

cb61699

google Map is not a valid class

removed unsigned fro EnteredBy for Person and Family

c5e1c6a

to support -1 as self regestration

self reg has EnteredBy = -1

2f6aa52

Note Created By Now works for Self Registration

bec4491

DawoudIO removed the please address comments label Oct 22, 2016

crossan007 reviewed Oct 22, 2016

View reviewed changes

DawoudIO merged commit 024c8d5 into develop Oct 22, 2016

DawoudIO deleted the external-mvc-site branch October 22, 2016 18:15

DawoudIO removed the In Review label Mar 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Self Registration #935

Self Registration #935

DawoudIO commented Aug 26, 2016 •

edited

Loading

crossan007 Sep 2, 2016

crossan007 commented Oct 20, 2016

crossan007 commented Oct 20, 2016

crossan007 commented Oct 20, 2016 •

edited

Loading

crossan007 Oct 20, 2016

DawoudIO Oct 21, 2016

crossan007 commented Oct 20, 2016

crossan007 commented Oct 20, 2016 •

edited

Loading

crossan007 Oct 21, 2016

DawoudIO Oct 21, 2016

crossan007 Oct 21, 2016

DawoudIO Oct 21, 2016

DawoudIO Oct 21, 2016

DawoudIO Oct 21, 2016

crossan007 Oct 21, 2016

DawoudIO Oct 21, 2016

crossan007 Oct 22, 2016

crossan007 Oct 22, 2016

Self Registration #935

Self Registration #935

Conversation

DawoudIO commented Aug 26, 2016 • edited Loading

Choose a reason for hiding this comment

crossan007 commented Oct 20, 2016

crossan007 commented Oct 20, 2016

crossan007 commented Oct 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crossan007 commented Oct 20, 2016

crossan007 commented Oct 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DawoudIO commented Aug 26, 2016 •

edited

Loading

crossan007 commented Oct 20, 2016 •

edited

Loading

crossan007 commented Oct 20, 2016 •

edited

Loading