Find email duplicates API #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
crossan007
approved these changes
Dec 30, 2017
src/api/routes/email.php
Outdated
| function getEmailDupes(Request $request, Response $response, array $p_args) | ||
| { | ||
| $connection = Propel::getConnection(); | ||
| $dupEmailsSQL = "select email from emails_duplicate;"; |
There was a problem hiding this comment.
please make the SQL statements CAPITALIZED to keep with standard SQL convention.
|
This is for 2.10.0, since it has a DB script, correct? |
|
correct, this is 2.10.0 |
|
looks like i missed adding to view on new install.. adding that back |
…M/CRM into feature/find-email-dups
|
in testing, I noticed our vagrant is running MySQL 5.7.20 the way the create view is done does not work pre - MySQL 5.7.7 |
|
now it is ready |
crossan007
requested changes
Jan 4, 2018
crossan007
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
What Issues does it Close?
part of #3787
Test via
http://192.168.33.10/api/emails/duplicates