Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countries and States Rest APIs #3782

Merged
merged 3 commits into from
Dec 24, 2017
Merged

Countries and States Rest APIs #3782

merged 3 commits into from
Dec 24, 2017

Conversation

DawoudIO
Copy link
Contributor

What's this PR do?

Address new APIs to return a list of all countries in the system & an new api to return list of states if a locale file is found on disk

/api/public/data/countries/
/api/public/data/countries/ca/states
/api/public/data/countries/us/states

What Issues does it Close?

Closes #3781

Where should the reviewer start?

REST Client to make the call and see results, also test counties where we don't have state data.

@ghost ghost assigned DawoudIO Dec 24, 2017
@ghost ghost added the In Review label Dec 24, 2017
@DawoudIO
Copy link
Contributor Author

DawoudIO commented Dec 24, 2017

This idea came out of @phili67's #3763 so that we can use select2 to fill in the values.

Also now with this change you can create a fr.json file and have the list of states in France show up.

Copy link
Contributor

@crossan007 crossan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DawoudIO DawoudIO merged commit ff7f59e into master Dec 24, 2017
@ghost ghost removed the In Review label Dec 24, 2017
@DawoudIO DawoudIO added this to the 2.9.3 milestone Dec 24, 2017
@DawoudIO DawoudIO deleted the country-state-dto branch December 29, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants