-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better UI dependency management and code path #324
Conversation
DawoudIO
commented
Feb 15, 2016
- created a top level composer file
- download and install driftyco/ionicons for offline support - closes Support Running the CRM offline #48
- download and install font-awesome for offline support - closes Support Running the CRM offline #48
- moved adminlte from church info composer file to ui composer file
- when a vagrant system starts, it download the skin dependency via composer and copy the correct files into the /skin dir
…ont-awesome": all moved from vendor dir to skin dir inside church info
"components/font-awesome": "4.5.0" added to the skin dir for usage later on
OK this is ready for a merge... |
I'll fix the merge conflicts tonight after i get approval for this PR |
This is ready |
I cant find where you're calling this "build-skin.sh" script. It's not in the vagrant file, or in bootstrap.sh Also, |
So the sql issue is line ending... I thought I fixed that. As for the skin build it is a shell script that runs manually once you ssh into the vagrant box |
I SSH'd into the box, and |
It is located in /dev/churchcrm I need to add a dev read me |
I see that, but I don't think we should override the vagrant default: https://www.vagrantup.com/docs/synced-folders/ I don't think it's an unreasonable expectation for someone launching a vagrant environment that |
ok i pushed a line ending fix on this branch. |
Having an actual filesystem mounted under /dev is rather unusual. That directory is usually reserved for device "files" that represent an interface to the kernel space. |
ok let me see if i can get /vagrant, the issue is that i need things outside that dir. If i can get it working with /vagrant i'll fix and merge |
Better UI dependency management and code path