Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GroupEditor.js.php #2740

Closed
wants to merge 2 commits into from
Closed

Create GroupEditor.js.php #2740

wants to merge 2 commits into from

Conversation

phili67
Copy link

@phili67 phili67 commented Jul 7, 2017

Better traduction of DataTable

@phili67
Create GroupEditor.js.php
ee80be2 
Better traduction of DataTable
@ghost ghost assigned phili67 Jul 7, 2017
@ghost ghost added the In Review label Jul 7, 2017
@crossan007 crossan007 self-requested a review July 7, 2017 22:01
crossan007
crossan007 requested changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@crossan007 crossan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be rendering whole JavaScript files in PHP just for translation.

Let's get the JavaScript based translation working.

@phili67
Copy link
Author

phili67 commented Jul 8, 2017 •
edited
Loading

Ok, but it's very unstable.
Second, the POeditor can't make the extraction ..... of js files.
Most of the time nothing work

@crossan007
Copy link
Contributor

This is superseded by #2762.

We are not going to create .js.php files - rather, let us fix the problems with i18next.

@crossan007 crossan007 closed this Jul 9, 2017
@ghost ghost removed the In Review label Jul 9, 2017
@DawoudIO DawoudIO deleted the phili67-patch-9-1 branch July 11, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crossan007 crossan007 crossan007 requested changes

Assignees

@phili67 phili67

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phili67 @crossan007