System Logs v2 #2424
System Logs v2 #2424
Conversation
- if debug is on - then use file logger to a local file - if debug is off - then use a null handler
ghost
assigned 
| @@ -289,7 +289,7 @@ function RunQuery($sSQL, $bStopOnError = true) | |||
| if ($result = mysqli_query($cnInfoCentral, $sSQL)) { | |||
| return $result; | |||
| } elseif ($bStopOnError) { | |||
| if (SystemConfig::getValue('debug')) { | |||
| if (SystemConfig::getValue('sLogLevel ') == "100") { // debug level | |||
There was a problem hiding this comment.
maybe make this write to the log instead of die()
There was a problem hiding this comment.
also, if DEBUG is set, all queries should be logged.
There was a problem hiding this comment.
hmmm that is now outside MVP... the goal of this PR is to ensure we don't crash... please open a issue to track it
|
|
||
| // ORM Logs | ||
| $ormLogger = new Logger('ormLogger'); | ||
| $dbClassName = "\\Propel\\Runtime\\Connection\\DebugPDO"; |
There was a problem hiding this comment.
I think we need a conditional here:
https://github.com/ChurchCRM/CRM/pull/2278/files#diff-e9848400293ecb36fea0aef7708d40f5R138
There was a problem hiding this comment.
http://propelorm.org/documentation/07-logging.html
You can also disable the debug mode at runtime, by calling PropelPDO::useDebug(false). Using this method, you can choose to enable the debug mode for only one particular query, or for all queries.
Alternatively, you can ask Propel to always enable the debug mode for a particular connection by using the Propel\Runtime\Connection\DebugPDO class instead of the default ConnectionWrapper class. This is accomplished in the configuration file, in the classname node of a given datasource connection (see the configuration reference for more details).
There was a problem hiding this comment.
again please open an issue to track, the goal was not to crash the system
|
please approve as this is a P0 in prod systems |
overtakes #2278