System Settings Cleanup #2392

DawoudIO · 2017-04-25T04:38:13Z

removed checks for strang default values - closes System Settings: sToEmailAddress where is it used #2386
changed iPersonNameStyle to drop down with values 1 to 6 - Closes iPersonNameStyle Admin setting needs to be a drop-down list #2133
created a backup tab - closes System Settings: Backup tab #2390
removed unused sXML_RPC_PATH - closes System Settings: sXML_RPC_PATH where is it used #2393
created an Integration tab closes System Settings: Create an Integration Tab #2387
iFYMonth is now a dropdown with 1 to 12 closes System Settings - iFYMonth should be a dropdown #2384
added setting type password - closes System Settings - Passwords #2383
fixed all vars to ensure they start with the correct prefix String -> s, Integer -> i, Boolean ->b , Array -> a closes System Settings: Members #2388
removed sGeocoderID sGeocoderPW
Name choices now has more info int he drop down

bEnableSelfRegistration,bForceUppercaseZip are both boolean, changed to start with b and used getBooleanValue where needed closes #2388 closes #2388

String -> s, Integer -> i, Boolean ->b , Array -> a

crossan007 · 2017-04-25T12:20:23Z

how about adding #1849 to this PR?

DawoudIO · 2017-04-25T13:48:33Z

I tried but it was bigger than you think as the system setting pages uses ids... So I revert it

DawoudIO · 2017-04-26T03:15:51Z

this is ready for testing

DawoudIO · 2017-04-30T00:39:46Z

once we merge a few more things to Master and merge them back to develop i have to dbl check a few items here

DawoudIO · 2017-05-06T15:57:20Z

@crossan007 I'm not sure why the tests are failing in the branch doing the testing via browser i see the pages

crossan007 · 2017-05-12T02:27:42Z

src/Include/analyticstracking.php

@@ -1,7 +1,7 @@
 <?php
 use ChurchCRM\dto\SystemConfig;

-$googleTrackingID = SystemConfig::getValue('googleTrackingID');
+$googleTrackingID = SystemConfig::getValue('sGoogleTrackingID');


crossan007 · 2017-05-12T02:32:17Z

src/ChurchCRM/dto/ConfigItem.php

-  private $id, $name, $value, $type, $default, $tooltip, $data, $dbConfigItem;
-  public function __construct($id, $name, $type, $default, $tooltip, $data='') {
+  private $id, $name, $value, $type, $default, $tooltip, $url, $data, $dbConfigItem;
+  public function __construct($id, $name, $type, $default, $tooltip, $url='', $data='') {


I like this, but it needs more work.

there are some config settings which provide incorrect values for this parameter:

I'm unclear on what you are showing me

crossan007 · 2017-05-12T02:35:02Z

src/SystemSettings.php

@@ -186,6 +186,12 @@
                                 value='<?= htmlspecialchars($setting->getValue(), ENT_QUOTES) ?>' class="form-control">
                        <?php

+                        } elseif ($setting->getType() == 'password') {


You missed sISTpassword

crossan007

Just a few changes - fix the URL setting parameter order / count and the sISTPassword field

DawoudIO · 2017-05-13T21:29:13Z

We need to merge this soon as it will be a merge nightmare merge

crossan007 · 2017-05-13T21:31:08Z

Can you fix the issue I commented on for multi-valued settings using the value-choices of that setting as the link?

that's the only thing needed to merge this.

DawoudIO · 2017-05-15T15:06:23Z

ok sISTpassword updated let me know if you see other stuff needing changes

crossan007 · 2017-05-15T16:44:02Z

The "link URL" that appears when you hover over the link for the setting does not contain a valid address- instead it shows the choices available for that multiple choice selection

DawoudIO · 2017-05-20T20:11:10Z

this is now good to go... i tested the URLs and make a few more changes but I'll merge this after it pass the checks

crossan007 · 2017-05-20T20:16:05Z

src/SystemSettings.php

@@ -247,7 +247,7 @@ class="form-control">
                      }
                      if (!empty($setting->getUrl())) {
                          ?>
-                            <a href="<?= $setting->getUrl() ?>"><i class="fa fa-fw fa-link"></i></a>
+                            <a href="<?= $setting->getUrl() ?>" target="_blank"><i class="fa fa-fw fa-link"></i></a>


removed checks for strang default values #2386

d2ca6b4

ghost assigned DawoudIO Apr 25, 2017

ghost added the In Review label Apr 25, 2017

DawoudIO added 2 commits April 24, 2017 21:41

moved iPersonNameStyle to a dropdown #2389

dfafda5

Created a backup tab and reorder of tabs

908be60

#2390

DawoudIO added this to the 2.8.0 milestone Apr 25, 2017

DawoudIO added 9 commits April 24, 2017 21:52

removed sXML_RPC_PATH #2393

ae26d58

created an Integration tab #2387

12f6781

integration tab

bd36c88

iFYMonth is now a dropdown #2384

a7810ce

added password type

f8d8646

using type password

d78bd9f

System Settings: Members (bEnableSelfRegistration,bForceUppercaseZip)

b575546

bEnableSelfRegistration,bForceUppercaseZip are both boolean, changed to start with b and used getBooleanValue where needed closes #2388 closes #2388

Config Name cleanup

df6aefc

String -> s, Integer -> i, Boolean ->b , Array -> a

adding support for URLs for docs etc

2095e06

DawoudIO added bug development enhancement Backend System labels Apr 25, 2017

DawoudIO requested a review from crossan007 April 25, 2017 06:15

DawoudIO added 2 commits April 25, 2017 06:49

Apply fixes from StyleCI (#2397)

ffa62a7

updated tabs

48d44d3

Merge branch 'develop' into system-settings-cleanup

5dd7779

crossan007 added 2 commits May 11, 2017 22:20

unbreak bSMTPAuth

b037110

fix bDebug

a7e2a8d

crossan007 reviewed May 12, 2017

View reviewed changes

crossan007 requested changes May 12, 2017

View reviewed changes

DawoudIO added 2 commits May 15, 2017 08:03

Merge branch 'develop' into system-settings-cleanup

ee11fb6

updated sISTpassword to password

362a9e7

DawoudIO added 3 commits May 20, 2017 13:10

Open link in a new page

ad47a63

tooltip is now optional

545e7b1

fixed URLs & Better Config for Name Choices

b6b1cb1

crossan007 reviewed May 20, 2017

View reviewed changes

crossan007 approved these changes May 20, 2017

View reviewed changes

DawoudIO merged commit 827d7d1 into develop May 20, 2017

ghost removed bug In Review labels May 20, 2017

DawoudIO deleted the system-settings-cleanup branch May 20, 2017 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

System Settings Cleanup #2392

System Settings Cleanup #2392

DawoudIO commented Apr 25, 2017 •

edited

Loading

crossan007 commented Apr 25, 2017

DawoudIO commented Apr 25, 2017

DawoudIO commented Apr 26, 2017

DawoudIO commented Apr 30, 2017

DawoudIO commented May 6, 2017

crossan007 May 12, 2017

crossan007 May 12, 2017

DawoudIO May 15, 2017

crossan007 May 12, 2017

crossan007 left a comment

DawoudIO commented May 13, 2017

crossan007 commented May 13, 2017

DawoudIO commented May 15, 2017

crossan007 commented May 15, 2017

DawoudIO commented May 20, 2017

crossan007 May 20, 2017

System Settings Cleanup #2392

System Settings Cleanup #2392

Conversation

DawoudIO commented Apr 25, 2017 • edited Loading

crossan007 commented Apr 25, 2017

DawoudIO commented Apr 25, 2017

DawoudIO commented Apr 26, 2017

DawoudIO commented Apr 30, 2017

DawoudIO commented May 6, 2017

crossan007 May 12, 2017

Choose a reason for hiding this comment

crossan007 May 12, 2017

Choose a reason for hiding this comment

DawoudIO May 15, 2017

Choose a reason for hiding this comment

crossan007 May 12, 2017

Choose a reason for hiding this comment

crossan007 left a comment

Choose a reason for hiding this comment

DawoudIO commented May 13, 2017

crossan007 commented May 13, 2017

DawoudIO commented May 15, 2017

crossan007 commented May 15, 2017

DawoudIO commented May 20, 2017

crossan007 May 20, 2017

Choose a reason for hiding this comment

DawoudIO commented Apr 25, 2017 •

edited

Loading