Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiosk Checkin / Out #2333

Merged
merged 87 commits into from
May 27, 2017
Merged

Kiosk Checkin / Out #2333

merged 87 commits into from
May 27, 2017

Conversation

crossan007
Copy link
Contributor

@crossan007 crossan007 commented Apr 20, 2017

Related Issues

closes #812
closes #2329
helps with #1144
causes us to look at #462 and #1947
serves as base for #2468
first SMS integration: #2149

Details

Documentation here: https://github.com/ChurchCRM/CRM/wiki/Kiosk-Devices

image

alerting

@crossan007 crossan007 added this to the 2.8.0 milestone Apr 20, 2017
@ghost ghost assigned crossan007 Apr 20, 2017
@ghost ghost added the In Review label Apr 20, 2017
@crossan007 crossan007 changed the title 2.4.0 sundayschool classroom utilities sundayschool classroom utilities Apr 20, 2017
@crossan007 crossan007 changed the title sundayschool classroom utilities Feature/sundayschool classroom utilities Apr 22, 2017
@crossan007 crossan007 changed the title Feature/sundayschool classroom utilities (Kiosk Group Checkin / out) Kiosk Checkin / Out May 20, 2017
@@ -291,6 +291,9 @@
<foreign-key foreignTable="group_grp">
<reference local="p2g2r_grp_ID" foreign="grp_ID"/>
</foreign-key>
<foreign-key foreignTable="list_lst">
<reference local="p2g2r_rle_ID" foreign="lst_OptionID"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used on line 23 in GroupQuery.php

Copy link
Contributor

@DawoudIO DawoudIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i yet to test it, but i wanted to do a quick review of the code

public function getTokens()
{
$myTokens = [
"toName" => "Guardian(s) of ". $this->notificationSource,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get this text

$message = $client->message()->send([
'to' => $recipient->getNumericCellPhone(),
'from' => SystemConfig::getValue("sNexmoFromNumber"),
'text' => 'Notification for ' . $this->person->getFullName()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gettext


public function getNumericCellPhone()
{
//return $this->getCellPhone();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

<?php

/*
* To change this license header, choose License Headers in Project Properties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

}
}

public static function random_word( $length = 6 ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly registered kiosks get a "random name"

<?php
/*******************************************************************************
*
* filename : Dashboard.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/past


<script>

window.CRM.APIRequest = function(options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this move to a .js file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going into the crmjsom :-)


$this->get('/', function ($request, $response, $args) {
$Kiosks = KioskDeviceQuery::create()
->joinWithKioskAssignment(\Propel\Runtime\ActiveQuery\Criteria::LEFT_JOIN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a "use" link to cleanup the code


$this->post('/{kioskId:[0-9]+}/identifyKiosk', function ($request, $response, $args) {
$kioskId = $args['kioskId'];
$identify = \ChurchCRM\KioskDeviceQuery::create()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for the package

@@ -79,7 +79,8 @@ INSERT INTO `menuconfig_mcf` (`mid`, `name`, `parent`, `ismenu`, `content_englis

(80, 'report', 'root', 1, 'Data/Reports', 'Data/Reports', '', '', 'bAll', NULL, 0, 0, NULL, 1, 9, 'fa-file-pdf-o'),
(81, 'reportmenu', 'report', 0, 'Reports Menu', 'Reports Menu', 'ReportList.php', '', 'bAll', NULL, 0, 0, NULL, 1, 1, NULL),
(82, 'querymenu', 'report', 0, 'Query Menu', 'Query Menu', 'QueryList.php', '', 'bAll', NULL, 0, 0, NULL, 1, 2, NULL);
(82, 'querymenu', 'report', 0, 'Query Menu', 'Query Menu', 'QueryList.php', '', 'bAll', NULL, 0, 0, NULL, 1, 2, NULL),
(83, 'kioskmanager', 'root', 0, 'Kiosk Manager', 'Kiosk Manager', 'KioskManager.php', '', 'bAll', NULL, 0, 0, NULL, 1, 10, 'fa-laptop');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should go on the right Nav not the main one and only for admins

@DawoudIO DawoudIO merged commit 77d03e2 into develop May 27, 2017
@ghost ghost removed the In Review label May 27, 2017
@DawoudIO DawoudIO deleted the 2.4.0-sundayschool-classroom-utilities branch May 27, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants