Fix #1921 and others untranslated terms #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1921 and others untranslated terms
DawoudIO
requested changes
Feb 13, 2017
src/QueryView.php
Outdated
| @@ -302,8 +302,8 @@ function getQueryFormInput($queryParameters) | |||
| extract($queryParameters); | |||
|
|
|||
| $input = ''; | |||
| $label = '<label>' . $qrp_Name . '</label>'; | |||
| $helpMsg = '<div>' . $qrp_Description . '</div>'; | |||
| $label = '<label>' . gettext ($qrp_Name) . '</label>'; | |||
There was a problem hiding this comment.
Sorry ... I tested this before submit PR, and works fine...
src/SystemSettings.php
Outdated
| @@ -128,7 +128,7 @@ | |||
| <li class="<?php if ($category == 'Church Information') { | |||
| echo 'active'; | |||
| } ?>"><a href="#<?= str_replace(" ", '', $category) ?>" data-toggle="tab" | |||
| aria-expanded="false"><?= $category ?></a> | |||
| aria-expanded="false"><?= gettext($category) ?></a> | |||
There was a problem hiding this comment.
the categories need to be localized
There was a problem hiding this comment.
The categories are in POEditor.com since older versions. This stop working in 2.6.0-RC1 ....
revert gettext($category)
DawoudIO
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1921 and others untranslated terms