Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete of system user works but gives a large error message #5175

Closed
ChurchCRMBugReport opened this issue Mar 8, 2020 · 1 comment
Closed

Comments

@ChurchCRMBugReport
Copy link

ChurchCRMBugReport commented Mar 8, 2020

When you do a delete of a system user it works fine but it gives a large error message shown below:

ERROR
Error making API Call to: /matrikel/api/users/237

Error text: Identifier "Logger" is not defined.

Stack Trace:

[
  "#0 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/Container.php(172): Slim\\Container->get('Logger')",
  "#1 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/api/routes/users/users-admin.php(70): Slim\\Container->__get('Logger')",
  "#2 [internal function]: Closure->{closure}(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Array)",
  "#3 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(41): call_user_func(Object(Closure), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Array)",
  "#4 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/Route.php(335): Slim\\Handlers\\Strategies\\RequestResponse->__invoke(Object(Closure), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Array)",
  "#5 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/ChurchCRM/Slim/Middleware/Request/Auth/BaseAuthRoleMiddleware.php(28): Slim\\Route->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#6 [internal function]: ChurchCRM\\Slim\\Middleware\\Request\\Auth\\BaseAuthRoleMiddleware->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Slim\\Route))",
  "#7 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/DeferredCallable.php(43): call_user_func_array(Object(ChurchCRM\\Slim\\Middleware\\Request\\Auth\\AdminRoleAuthMiddleware), Array)",
  "#8 [internal function]: Slim\\DeferredCallable->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Slim\\Route))",
  "#9 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\\DeferredCallable), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Slim\\Route))",
  "#10 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\\Route->Slim\\{closure}(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#11 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/Route.php(313): Slim\\Route->callMiddlewareStack(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#12 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/App.php(495): Slim\\Route->run(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#13 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/ChurchCRM/Slim/Middleware/VersionMiddleware.php(13): Slim\\App->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#14 [internal function]: ChurchCRM\\Slim\\Middleware\\VersionMiddleware->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Slim\\App))",
  "#15 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/DeferredCallable.php(43): call_user_func_array(Object(ChurchCRM\\Slim\\Middleware\\VersionMiddleware), Array)",
  "#16 [internal function]: Slim\\DeferredCallable->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Slim\\App))",
  "#17 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\\DeferredCallable), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Slim\\App))",
  "#18 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/ChurchCRM/Slim/Middleware/AuthMiddleware.php(38): Slim\\App->Slim\\{closure}(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#19 [internal function]: ChurchCRM\\Slim\\Middleware\\AuthMiddleware->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Closure))",
  "#20 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/DeferredCallable.php(43): call_user_func_array(Object(ChurchCRM\\Slim\\Middleware\\AuthMiddleware), Array)",
  "#21 [internal function]: Slim\\DeferredCallable->__invoke(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Closure))",
  "#22 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\\DeferredCallable), Object(Slim\\Http\\Request), Object(Slim\\Http\\Response), Object(Closure))",
  "#23 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\\App->Slim\\{closure}(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#24 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/App.php(388): Slim\\App->callMiddlewareStack(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#25 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/vendor/slim/slim/Slim/App.php(296): Slim\\App->process(Object(Slim\\Http\\Request), Object(Slim\\Http\\Response))",
  "#26 /customers/0/e/8/pingsteskilstunaweb.se/httpd.www/matrikel/api/index.php(76): Slim\\App->run()",
  "#27 {main}"
]
Collected Value Title Data
Page Name /matrikel/UserList.php
Screen Size 1080x1920
Window Size 937x1920
Page Size 937x1920
Platform Information Linux pingsteskilstunaweb.se 5.3.0-26-generic #28~18.04.1-Ubuntu SMP Wed Dec 18 16:40:14 UTC 2019 x86_64
PHP Version 7.3.15
SQL Version 5.5.5-10.3.21-MariaDB-1:10.3.21+maria~bionic
ChurchCRM Version 4.0.2
Reporting Browser Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36
Prerequisite Status All Prerequisites met
Integrity check status {"status":"failure","message":"En eller flera filer misslyckades signaturvalidering","files":[{"filename":"locale/js/sv_SE.js","status":"Hash Mismatch","expectedhash":"e1a2fe64f0fd286be53daad2046daa98a4f85233","actualhash":"b174479148be804885ff0cbb68c74abaabb7354a"}]}
@crossan007 crossan007 added the bug label Mar 10, 2020
@crossan007 crossan007 added this to the Backlog milestone Mar 10, 2020
@crossan007 crossan007 self-assigned this Mar 10, 2020
@crossan007
Copy link
Contributor

Specifically, this error occurs after a user is deleted and the email failed to send to the user either due to invalid SMTP settings, or because the SMTP server rejected the message.

That said, deleting a user should almost certainly NOT send an email to the user telling them their account has been deleted; this behavior seems a bit off to me. I think moving the control for this behavior to an admin-configurable setting would be appropriate

@crossan007 crossan007 modified the milestones: Backlog, 4.0.3 Mar 11, 2020
crossan007 added a commit that referenced this issue Mar 11, 2020
Relates to #5175

When users are deleted from ChurchCRM by an admin, there's a good chance the admin does not want an email to be sent to the user informing the user that their account has been deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants