Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.9.0 upgrade script fails #4081

Closed
crossan007 opened this issue Mar 7, 2018 · 1 comment
Closed

2.9.0 upgrade script fails #4081

crossan007 opened this issue Mar 7, 2018 · 1 comment
Assignees
@crossan007
Labels
bug Installation / Upgrade
Milestone
3.0.0

Comments

@crossan007
Copy link
Contributor

2.9.0-InnoDB.php tries to alter tables to use InnoDB, but fails when the database restore is from a version before 2.9.0.

In these cases, the views created in 2.9.0 may still linger in the database, and are within the scope of the 2.9.0 upgrade script. Views cannot be converted to innodb, and will cause the whole upgrade to fail.
@crossan007 crossan007 added this to the 3.0.0 milestone Mar 7, 2018
@crossan007 crossan007 self-assigned this Mar 7, 2018
@crossan007
Copy link
Contributor Author

discovered while testing #3420

crossan007 added a commit that referenced this issue Mar 7, 2018
@crossan007
closes #4081
1702bda
@crossan007 crossan007 mentioned this issue Mar 7, 2018
Merged
10 tasks
@ghost ghost added In Review and removed bug labels Mar 7, 2018
DawoudIO pushed a commit that referenced this issue Mar 7, 2018
@crossan007 @DawoudIO
Bugfix/misc 3.0.0 bugs (#4085)
98960fc 
* closes #4078

* closes #4077

* closes #4079

* closes #4082

* closes #4081

* Apply fixes from StyleCI (#4084)

* closes #4085

* Type-check upgrade script extension && minor self-code-review

* Handle invalid upgrade file steps
@ghost ghost removed the In Review label Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crossan007 crossan007

Labels
bug Installation / Upgrade
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@crossan007